Workflow for deleted packets #94
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #94 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 38 38
Lines 3147 3165 +18
=========================================
+ Hits 3147 3165 +18
☔ View full report in Codecov by Sentry. |
R/outpack_helpers.R
Outdated
| cmd <- sprintf( | ||
| 'orderly2::orderly_validate_archive("%s", action = "orphan")', id) | ||
| cli::cli_abort( | ||
| c("Unable to copy files, due to corrupt packet {id}", |
There was a problem hiding this comment.
Chatted about this corrupt does look a bit scary! But hard to think of something much better. "invalid" is not quite accurate. If we could detect accurately it is corrupted because they have deleted something I think it would be good to indicate that in this message to link this message up with the action the user will have taken to get them in this state.
There was a problem hiding this comment.
I've updated this to use either "locally modified" or "deleted" in place of "corrupt" which should be friendlier and also hint at the true problem (see 1a05fa7)
As prompted by @pwinskill, this PR tidies up how users can delete from their archive without causing any major problems. The core feature introduced here is that we now throw (perhaps too) informative error messages when pulling in a dependency fails because of an inconsistency between the metadata store and the packets on disk. This error tries to explain the situation and prompts for a resolution. I've then outlined this in the introduction vignette in a section "Deleting things from the archive" which we'll be able to point people at when this question comes up in future.
Merge after #92, as it contains those commits and depends on that functionality.