Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for validating packets #92

Merged
merged 4 commits into from
Aug 25, 2023
Merged

Add support for validating packets #92

merged 4 commits into from
Aug 25, 2023

Conversation

richfitz
Copy link
Member

This PR adds support for validating that packet contents are ok in the archive. This is about the 5th time I've tried to implement this and the first one that I have liked, made possible by our current use of cli, and the pattern of converting dots into a query.

I've held off from implementing repair here, as there are a few options for doing that (pulling from the filestore is trivial, finding other local files is easy enough but will miss many, pulling from a location should be the fallback).

I'm going to work up a second pull request that adds high-level docs and a workflow that encourages users to try running this.

@richfitz richfitz requested a review from r-ash August 25, 2023 11:33
@richfitz richfitz marked this pull request as ready for review August 25, 2023 11:33
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (9a1c9ec) 100.00% compared to head (cc5d450) 100.00%.

❗ Current head cc5d450 differs from pull request most recent head 9311ea0. Consider uploading reports for the commit 9311ea0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #92   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           37        38    +1     
  Lines         3089      3147   +58     
=========================================
+ Hits          3089      3147   +58     
Files Changed Coverage Δ
R/outpack_hash.R 100.00% <ø> (ø)
R/location.R 100.00% <100.00%> (ø)
R/outpack_index.R 100.00% <100.00%> (ø)
R/validate.R 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@r-ash r-ash merged commit ff8029e into main Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants