Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix continuous benchmarking: #338

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Fix continuous benchmarking: #338

merged 1 commit into from
Oct 3, 2024

Conversation

giovannic
Copy link
Member

@giovannic giovannic requested a review from plietar October 3, 2024 09:30
@plietar
Copy link
Member

plietar commented Oct 3, 2024

Thanks. Merging this into main as that's where GitHub looks for actions that react to comments.

@plietar plietar changed the base branch from dev to master October 3, 2024 10:50
@plietar
Copy link
Member

plietar commented Oct 3, 2024

Ah of course just re-targeting the base branch isn't enough. @giovannic could you rebase on master and update/merge the PR please.

@giovannic
Fix continuous benchmarking:
2513ae3 
 * Bump touchstone download artifact version to match [lorenzwalthert's version](https://github.com/lorenzwalthert/touchstone/blob/main/actions/receive/action.yaml#L139)
@giovannic
Copy link
Member Author

Thanks, done!

@plietar plietar merged commit 9b45441 into master Oct 3, 2024
4 checks passed
@giovannic giovannic deleted the bug/benchmark branch October 3, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plietar plietar plietar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giovannic @plietar