Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p.v constant asymptomatic infectivity #316

Conversation

RJSheppard
Copy link
Member

p.v has a constant asymptomatic infectivity, in contrast to p.f where infectivity is affected by age and immunity. We must therefore change this when asymptomatic infectivity is assigned (when an individual become asymptomatic). This occurs in initial assignments, when someone becomes infected to an asymptomatic status infection and when a clinical diseased individual recovers to asymptomatic. We can now use the existing update_infection() function for vivax in human_infection and in disease progression.

We now remove the gamma1 parameter from the vivax parameter list, used in the falciparum code.

Copy link
Member

@pwinskill pwinskill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Richard - one Q and a possible test simplification

R/human_infection.R Outdated Show resolved Hide resolved
tests/testthat/test-vivax.R Outdated Show resolved Hide resolved
@pwinskill
Copy link
Member

/benchmark

@RJSheppard RJSheppard force-pushed the vivax_competing_hazards_main_parameters branch from 3386313 to e1060c0 Compare September 16, 2024 15:54
@RJSheppard RJSheppard force-pushed the vivax_competing_hazards_main_constant_asymptomatic_infectivity branch 3 times, most recently from 7236985 to 5cb5a1e Compare September 17, 2024 10:31
@RJSheppard RJSheppard force-pushed the vivax_competing_hazards_main_parameters branch 2 times, most recently from f48ac97 to c3dc720 Compare September 17, 2024 10:53
@RJSheppard RJSheppard force-pushed the vivax_competing_hazards_main_constant_asymptomatic_infectivity branch from 5cb5a1e to ac353fd Compare September 17, 2024 11:56
@RJSheppard RJSheppard changed the base branch from vivax_competing_hazards_main_parameters to master September 17, 2024 11:58
@RJSheppard RJSheppard changed the base branch from master to dev September 17, 2024 11:59
@RJSheppard RJSheppard changed the base branch from dev to vivax_competing_hazards_main_parameters September 17, 2024 11:59
@RJSheppard RJSheppard force-pushed the vivax_competing_hazards_main_constant_asymptomatic_infectivity branch from ac353fd to 5cd9688 Compare September 17, 2024 12:08
@RJSheppard RJSheppard force-pushed the vivax_competing_hazards_main_constant_asymptomatic_infectivity branch from 5cd9688 to f5df32d Compare October 1, 2024 13:00
Base automatically changed from vivax_competing_hazards_main_parameters to dev October 1, 2024 14:18
… infectivity is affected by age and immunity. We must therefore change this when asymptomatic infectivity is assigned (when an individual become asymptomatic). This occurs in initial assignments, when someone becomes infected to an asymptomatic status infection and when a clinical diseased individual progresses to asymptomatic. We can use the existing update_infection() function for vivax in human_infection and in disease progression.

We can also now remove the gamma1 parameter from the vivax parameter list, used in the falciparum code.

The P.v vignette has been extended to include modelled infectivity details.
@giovannic giovannic force-pushed the vivax_competing_hazards_main_constant_asymptomatic_infectivity branch from f5df32d to 97837f3 Compare October 1, 2024 15:09
@giovannic
Copy link
Member

/benchmark

Copy link
Member

@giovannic giovannic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giovannic
Copy link
Member

/benchmark

Copy link

github-actions bot commented Oct 7, 2024

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 97837f3 is merged into dev:

  • ❗🐌large_population: 2.32m -> 2.39m [+1.95%, +4.03%]
  • ✔️small_population: 32.7s -> 32.7s [-0.86%, +0.96%]

Further explanation regarding interpretation and methodology can be found in the documentation.
Plots and raw data are available as artifacts of the workflow run.

@giovannic giovannic merged commit 3aabfee into dev Oct 7, 2024
5 checks passed
@giovannic giovannic deleted the vivax_competing_hazards_main_constant_asymptomatic_infectivity branch October 7, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants