Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CMake for the containers #331

Merged
merged 1 commit into from
Jun 12, 2020
Merged

Conversation

zebmason
Copy link
Contributor

One last try as I managed to search code in GitHub effectively at last

@zebmason zebmason force-pushed the update_cmake branch 16 times, most recently from e86694d to e86e1c4 Compare May 23, 2020 13:38
@zebmason
Copy link
Contributor Author

@matt-gretton-dann Two methods to build because either bionic or alpine fail

@zebmason zebmason marked this pull request as ready for review May 23, 2020 15:40
This was referenced May 23, 2020
@zebmason
Copy link
Contributor Author

zebmason commented Jun 2, 2020

@matt-gretton-dann
CMake upgraded across all containers as you asked for

@zebmason zebmason force-pushed the update_cmake branch 5 times, most recently from 032054f to 050e3af Compare June 5, 2020 06:51
@zebmason zebmason marked this pull request as draft June 5, 2020 07:00
@zebmason
Copy link
Contributor Author

zebmason commented Jun 5, 2020

@weshinsley Just rebased and OpenSuSe has started doing random errors. So converted to draft and will have a play tonight.

@zebmason zebmason marked this pull request as ready for review June 8, 2020 11:04
@zebmason
Copy link
Contributor Author

zebmason commented Jun 8, 2020

@weshinsley Looks like they changed the containers again. I remember Matt having to make some changes to the CI in the past when they did that.

@weshinsley weshinsley self-requested a review June 12, 2020 08:33
@weshinsley
Copy link
Collaborator

Since this was requested by Matt, looks good to me, and all the tests are passing, I'll merge in order to enable onward development...

@weshinsley weshinsley merged commit 0ba349b into mrc-ide:master Jun 12, 2020
@zebmason zebmason deleted the update_cmake branch June 12, 2020 15:39
@weshinsley
Copy link
Collaborator

(Ref Issue #233)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants