Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The IClientPublishOptions interface is missing the properties attribute #1074

Closed
wilcool opened this issue Apr 3, 2020 · 4 comments
Closed

Comments

@wilcool
Copy link

wilcool commented Apr 3, 2020

The IClientPublishOptions interface in the client-options.d.ts file is missing the properties attribute

image

@sublimator
Copy link
Member

IClientPublishOptions

Awwww such Java/C# ish names

@YoDaMa
Copy link
Contributor

YoDaMa commented Apr 24, 2020

I'mma say this is a bug... we have no testing for typescript interfaces.... we should probably have testing for the typescript interfaces....

Also this opens up one of the spiciest topics in TypeScript naming conventions, "I" prefixing interfaces or not. See: microsoft/TypeScript-Handbook#121 and also https://stackoverflow.com/questions/31876947/confused-about-the-interface-and-class-coding-guidelines-for-typescript/41967120#41967120

I'm not going to advocate for changing all the interfaces to non "I" prefixed, but we can definitely discuss it.

@github-actions
Copy link

This is an automated message to let you know that this issue has
gone 365 days without any activity. In order to ensure that we work
on issues that still matter, this issue will be closed in 14 days.

If this issue is still important, you can simply comment with a
"bump" to keep it open.

Thank you for your contribution.

@github-actions github-actions bot added the stale label Oct 15, 2022
@github-actions
Copy link

This issue was automatically closed due to inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants