From 869faadc68b0dedce25527f096b3e370785ce0f3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kacper=20Michaj=C5=82ow?= Date: Fri, 6 Oct 2023 23:54:37 +0200 Subject: [PATCH] options: disable --allow-delayed-peak-detect by default Peak detection greatly increases HDR experience. Performance hit of non-delayed detection is not that significant and is in line with current default settings. --- DOCS/interface-changes.rst | 1 + DOCS/man/options.rst | 2 +- etc/builtin.conf | 2 +- video/out/vo_gpu_next.c | 1 - 4 files changed, 3 insertions(+), 3 deletions(-) diff --git a/DOCS/interface-changes.rst b/DOCS/interface-changes.rst index 1d8a2592eb860..055651117a457 100644 --- a/DOCS/interface-changes.rst +++ b/DOCS/interface-changes.rst @@ -100,6 +100,7 @@ Interface changes - add `playlist-next-playlist` and `playlist-prev-playlist` commands - change `video-codec` to show description or name, not both - deprecate `--cdda-toc-bias` option, offsets are always checked now + - disable `--allow-delayed-peak-detect` by default --- mpv 0.36.0 --- - add `--target-contrast` - Target luminance value is now also applied when ICC profile is used. diff --git a/DOCS/man/options.rst b/DOCS/man/options.rst index 79171dc5dc156..5d89bcb77c6c7 100644 --- a/DOCS/man/options.rst +++ b/DOCS/man/options.rst @@ -6698,7 +6698,7 @@ them. frame when beneficial for performance. In particular, this is required to avoid an unnecessary FBO indirection when no advanced rendering is required otherwise. Has no effect if there already is an indirect pass, such as when - advanced scaling is enabled. Defaults to on. (Only affects + advanced scaling is enabled. Defaults to no. (Only affects ``--vo=gpu-next``, note that ``--vo=gpu`` always delays the peak.) ``--hdr-peak-percentile=<0.0..100.0>`` diff --git a/etc/builtin.conf b/etc/builtin.conf index 5cd184f42d50e..8ea64fdcc8dd9 100644 --- a/etc/builtin.conf +++ b/etc/builtin.conf @@ -48,12 +48,12 @@ correct-downscaling=no linear-downscaling=no sigmoid-upscaling=no hdr-compute-peak=no +allow-delayed-peak-detect=yes [high-quality] scale=ewa_lanczossharp hdr-peak-percentile=99.995 hdr-contrast-recovery=0.30 -allow-delayed-peak-detect=no deband=yes # Deprecated alias diff --git a/video/out/vo_gpu_next.c b/video/out/vo_gpu_next.c index 53147d55cf476..e2436f64f1919 100644 --- a/video/out/vo_gpu_next.c +++ b/video/out/vo_gpu_next.c @@ -2217,7 +2217,6 @@ const struct vo_driver video_out_gpu_next = { .uninit = uninit, .priv_size = sizeof(struct priv), .priv_defaults = &(const struct priv) { - .delayed_peak = true, .inter_preserve = true, },