Tests fail

[lucag]

I just noticed that sbt test fails:

~/t/gremlin-scala ❯❯❯ sbt test                                                                        master
[info] Loading settings from idea.sbt ...
[info] Loading global plugins from /Users/lucag/.sbt/1.0/plugins
[info] Loading settings from plugins.sbt ...
[info] Loading project definition from /Users/lucag/tmp/gremlin-scala/project
[info] Loading settings from version.sbt,build.sbt ...
[info] Set current project to root (in build file:/Users/lucag/tmp/gremlin-scala/)
[success] Total time: 5 s, completed Mar 23, 2018 1:29:31 PM
[info] Run completed in 28 milliseconds.
[info] Total number of tests run: 0
[info] Suites: completed 0, aborted 0
[info] Tests: succeeded 0, failed 0, canceled 0, ignored 0, pending 0
[info] No tests were executed.
[info] Compiling 16 Scala sources to /Users/lucag/tmp/gremlin-scala/gremlin-scala/target/scala-2.12/test-classes ...
[error] /Users/lucag/tmp/gremlin-scala/gremlin-scala/src/test/scala/gremlin/scala/TraversalSpec.scala:143:34: not found: value by
[error]         graph.V.value(Age).order(by(Order.decr)).toList
[error]                                  ^
[error] /Users/lucag/tmp/gremlin-scala/gremlin-scala/src/test/scala/gremlin/scala/TraversalSpec.scala:151:18: not found: value by
[error]           .order(by(Age))
[error]                  ^
[error] /Users/lucag/tmp/gremlin-scala/gremlin-scala/src/test/scala/gremlin/scala/TraversalSpec.scala:161:18: not found: value by
[error]           .order(by(Age, Order.decr))
[error]                  ^
[error] /Users/lucag/tmp/gremlin-scala/gremlin-scala/src/test/scala/gremlin/scala/TraversalSpec.scala:171:18: not found: value by
[error]           .order(by(__.outE(Created).count), by(Age, Order.decr))
[error]                  ^
[error] /Users/lucag/tmp/gremlin-scala/gremlin-scala/src/test/scala/gremlin/scala/TraversalSpec.scala:171:46: not found: value by
[error]           .order(by(__.outE(Created).count), by(Age, Order.decr))
[error]                                              ^
[error] /Users/lucag/tmp/gremlin-scala/gremlin-scala/src/test/scala/gremlin/scala/TraversalSpec.scala:252:16: not found: value by
[error]         .order(by(Order.decr))
[error]                ^
[error] /Users/lucag/tmp/gremlin-scala/gremlin-scala/src/test/scala/gremlin/scala/TraversalSpec.scala:277:44: not found: value by
[error]       favorite <- person.outE(Likes).order(by(Weight, Order.decr)).limit(1).inV
[error]                                            ^
[error] /Users/lucag/tmp/gremlin-scala/gremlin-scala/src/test/scala/gremlin/scala/TraversalSpec.scala:328:18: not found: value by
[error]           .group(by(Age))
[error]                  ^
[error] /Users/lucag/tmp/gremlin-scala/gremlin-scala/src/test/scala/gremlin/scala/TraversalSpec.scala:341:18: not found: value by
[error]           .group(by(__.value(Age)))
[error]                  ^
[error] /Users/lucag/tmp/gremlin-scala/gremlin-scala/src/test/scala/gremlin/scala/TraversalSpec.scala:352:23: not found: value by
[error]         graph.V.group(by.label).head
[error]                       ^
[error] /Users/lucag/tmp/gremlin-scala/gremlin-scala/src/test/scala/gremlin/scala/TraversalSpec.scala:365:18: not found: value by
[error]           .group(by { v: Vertex =>
[error]                  ^
[error] /Users/lucag/tmp/gremlin-scala/gremlin-scala/src/test/scala/gremlin/scala/TraversalSpec.scala:382:23: not found: value by
[error]         graph.V.group(by.label, by(Name)).head
[error]                       ^
[error] /Users/lucag/tmp/gremlin-scala/gremlin-scala/src/test/scala/gremlin/scala/TraversalSpec.scala:382:33: not found: value by
[error]         graph.V.group(by.label, by(Name)).head
[error]                                 ^
[error] /Users/lucag/tmp/gremlin-scala/gremlin-scala/src/test/scala/gremlin/scala/TraversalSpec.scala:402:45: not found: value by
[error]         graph.V.hasLabel(Person).groupCount(by(Age)).head
[error]                                             ^
[error] /Users/lucag/tmp/gremlin-scala/gremlin-scala/src/test/scala/gremlin/scala/TraversalSpec.scala:413:21: not found: value by
[error]       graph.V.dedup(by.label).value(Name).toSet shouldBe Set("marko", "lop")
[error]                     ^
[error] /Users/lucag/tmp/gremlin-scala/gremlin-scala/src/test/scala/gremlin/scala/TraversalSpec.scala:492:17: not found: value by
[error]           .path(by(Name), by(Age))
[error]                 ^
[error] /Users/lucag/tmp/gremlin-scala/gremlin-scala/src/test/scala/gremlin/scala/TraversalSpec.scala:492:27: not found: value by
[error]           .path(by(Name), by(Age))
[error]                           ^
[error] /Users/lucag/tmp/gremlin-scala/gremlin-scala/src/test/scala/gremlin/scala/TraversalSpec.scala:512:17: not found: value by
[error]           .path(by(Name), by.label)
[error]                 ^
[error] /Users/lucag/tmp/gremlin-scala/gremlin-scala/src/test/scala/gremlin/scala/TraversalSpec.scala:512:27: not found: value by
[error]           .path(by(Name), by.label)
[error]                           ^
[error] /Users/lucag/tmp/gremlin-scala/gremlin-scala/src/test/scala/gremlin/scala/TraversalSpec.scala:526:17: not found: value by
[error]           .path(by(Name), by.label)
[error]                 ^
[error] /Users/lucag/tmp/gremlin-scala/gremlin-scala/src/test/scala/gremlin/scala/TraversalSpec.scala:526:27: not found: value by
[error]           .path(by(Name), by.label)
[error]                           ^
[error] /Users/lucag/tmp/gremlin-scala/gremlin-scala/src/test/scala/gremlin/scala/TraversalSpec.scala:563:15: not found: value by
[error]         .path(by(Name))
[error]               ^
[error] /Users/lucag/tmp/gremlin-scala/gremlin-scala/src/test/scala/gremlin/scala/TraversalSpec.scala:609:31: not found: value by
[error]             .where(P.gt("a"), by(Age))
[error]                               ^
[error] /Users/lucag/tmp/gremlin-scala/gremlin-scala/src/test/scala/gremlin/scala/TraversalSpec.scala:622:36: not found: value by
[error]             .where("a", P.gt("b"), by(Age))
[error]                                    ^
[error] /Users/lucag/tmp/gremlin-scala/gremlin-scala/src/test/scala/gremlin/scala/TraversalSpec.scala:794:40: not found: value by
[error]         graph.V.hasLabel(Person).group(by(Name), by(CreatedCount)).head
[error]                                        ^
[error] /Users/lucag/tmp/gremlin-scala/gremlin-scala/src/test/scala/gremlin/scala/TraversalSpec.scala:794:50: not found: value by
[error]         graph.V.hasLabel(Person).group(by(Name), by(CreatedCount)).head
[error]                                                  ^
[error] /Users/lucag/tmp/gremlin-scala/gremlin-scala/src/test/scala/gremlin/scala/TraversalSpec.scala:891:24: not found: value by
[error]         .math("a + b", by(Age))
[error]                        ^
[error] /Users/lucag/tmp/gremlin-scala/gremlin-scala/src/test/scala/gremlin/scala/TraversalStrategySpec.scala:66:27: not found: value by
[error]           .sack(multiply, by(Weight))
[error]                           ^
[error] /Users/lucag/tmp/gremlin-scala/gremlin-scala/src/test/scala/gremlin/scala/TraversalStrategySpec.scala:79:27: not found: value by
[error]           .sack(multiply, by(__.value(Weight)))
[error]                           ^
[error] 29 errors found
[error] (gremlin-scala / Test / compileIncremental) Compilation failed
[error] Total time: 29 s, completed Mar 23, 2018 1:30:00 PM

[mpollmeier]

This works fine for me locally. However, this made me realise that travis.ci stopped building master some time ago, I'll need to figure out what's going on there. I guess if travis.ci builds it, this is a local issue on your machine.

[mpollmeier]

looks green to me... https://travis-ci.org/mpollmeier/gremlin-scala

[lucag]

I’ve tried it on a Linux machine (1.8.0_161-b12), and, as you say, everything works fine. But both on macOS (10.13.3, same JDK version) and Windows 7 SP1 (1.8.0_144-b01) the problem shows up as I described it.

I seems it’s an issue related to differences in file system case sensitivity among the different platforms. I tried enclosing the by object in another one (which I called oper), and of course modified the test code accordingly: the issue disappears and the tests compile and terminate with no errors.

[mpollmeier]

That's interesting. Turns out inside 'gremlin-scala/target/scala-2.12/classes/gremlin/scala/' there are both By.class (from trait By) and by.class (from object by). That's going to clash on case insensitive platforms. That's quite a non-obvious problem that can affect anyone. Have you seen this reported elsewhere? I'm wondering if scalac or sbt should do something about that.

For gremlin-scala it means one of the below, I haven't made up my mind yet:

1. leave as is and not care about case insensitive platforms
2. rename trait By to trait by
3. rename object by to object By (downside: DSL change, introducing a difference to gremlin-groovy)

I'm leaning towards 2). Thoughts?

[jec]

I've run into this same issue on macOS High Sierra using APFS with case insensitivity. I'm currently deciding between (1) reformatting my root filesystem or (2) developing my project in a Linux VM.

[mpollmeier]

I hope you didn't format your file system, I just went for option 3 and will release 3.3.2.0 now