Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests and enable CI for tests #25

Open
mpickering opened this issue May 8, 2020 · 9 comments
Open

Fix tests and enable CI for tests #25

mpickering opened this issue May 8, 2020 · 9 comments

Comments

@mpickering
Copy link
Owner

In classic @mpickering style, the tests are currently broken. It would be good if someone could fix the build and re-enable them in CI.

@ethercrow
Copy link

I fixed the building of tests in #38 but that was the easy part:

102 out of 247 tests failed (372.93s)

@mpickering
Copy link
Owner Author

Sounds like a good start at least. I imagine a lot of the tests fail because of changes due to multi-component requiring each cradle to explicitly list targets.

@jneira jneira self-assigned this May 20, 2020
@jneira
Copy link
Collaborator

jneira commented May 20, 2020

I'll give a try

@jneira
Copy link
Collaborator

jneira commented May 21, 2020

Well, the first step had been enable tests in azureci for linux and windows.
I had to disable hlint and -WError for both to get it reach running the tests: hls...jneira:wintests, so we should meka them work
It confirms the number of failing tests, same for both os's (nice 😉 ), 101-103: https://dev.azure.com/jneira/haskell-language-server/_build/results?buildId=775&view=results

The are quite fewer failing tests in the hls ghcide submodule version, i suppose it is not updated to last mpickering/hls version

@jneira
Copy link
Collaborator

jneira commented May 21, 2020

For reference this is the output of cabal test in my windows 10: https://gist.github.com/jneira/7d1048b47205c20eb4f73baea97be8f3

@jneira
Copy link
Collaborator

jneira commented May 21, 2020

If i run cabal run ghcide-tests instead cabal test there are only seven failing tests:
https://gist.github.com/jneira/7d1048b47205c20eb4f73baea97be8f3#file-test-report-cabal-run-txt

weird 🤔

@mpickering
Copy link
Owner Author

^ probably because it is using the version of ghcide on your path.

@jneira
Copy link
Collaborator

jneira commented May 21, 2020

@mpickering yeah, i forgot about that one (again 🤦‍♂️ )

@jneira
Copy link
Collaborator

jneira commented May 22, 2020

Hi, not sure if i could resolve the issue in a reasonable amount of time, given my knowledge of ghcide, its test suite and the changes of this branch 😟

I'll post my progresses anyway:

  • most tests creates an working remporal dir with no hie.yaml, i suppose that at least upstream ghcide does not need it
  • completions: all completions tests are failing and i am not sure why, the server returns an empty list of possible completions in all cases
  • code lenses: all of them failing
  • outline: all of them failing
  • get.definition: almost all of them failing
  • get.hover and get.type definition: all failing
  • cradle: all failing

@jneira jneira removed their assignment May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants