Add CSP header to web admin to ensure it matches needs (#3913)

sidekiq · Aug 5, 2018 · e339d23 · e339d23
1 parent 778b9cf
commit e339d23
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 0 deletions.
diff --git a/lib/sidekiq/web/application.rb b/lib/sidekiq/web/application.rb
@@ -7,6 +7,21 @@ class WebApplication
     CONTENT_LENGTH = "Content-Length"
     CONTENT_TYPE = "Content-Type"
     REDIS_KEYS = %w(redis_version uptime_in_days connected_clients used_memory_human used_memory_peak_human)
+    CSP_HEADER = [
+      "default-src 'self' https: http:",
+      "child-src 'self'",
+      "connect-src 'self' https: http: wss: ws:",
+      "font-src 'self' https: http:",
+      "frame-src 'self'",
+      "img-src 'self' https: http: data:",
+      "manifest-src 'self'",
+      "media-src 'self'",
+      "object-src 'none'",
+      "script-src 'self' https: http:",
+      "style-src 'self' https: http: 'unsafe-inline'",
+      "worker-src 'self'",
+      "base-uri 'self'"
+    ].join('; ').freeze
 
     def initialize(klass)
       @klass = klass
@@ -279,6 +294,7 @@ def call(env)
           "Content-Type" => "text/html",
           "Cache-Control" => "no-cache",
           "Content-Language" => action.locale,
+          "Content-Security-Policy" => CSP_HEADER
         }
 
         [200, headers, [resp]]

diff --git a/test/test_web.rb b/test/test_web.rb
@@ -54,6 +54,15 @@ def perform(a, b)
       assert_match(/Oversikt/, last_response.body)
     end
 
+    it 'can provide a default, appropriate CSP for its content' do
+      get '/', {}
+      policies = last_response.headers["Content-Security-Policy"].split('; ')
+      assert_includes(policies, "connect-src 'self' https: http: wss: ws:")
+      assert_includes(policies, "style-src 'self' https: http: 'unsafe-inline'")
+      assert_includes(policies, "script-src 'self' https: http:")
+      assert_includes(policies, "object-src 'none'")
+    end
+
     describe 'busy' do
 
       it 'can display workers' do