Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to disable paths/ignores verification, or set root directory #54

Open
TWiStErRob opened this issue Jul 10, 2023 · 1 comment
Open
Labels
pr-welcome This would be a good fix/feature, but the maintainer isn't planning on doing the work

Comments

@TWiStErRob
Copy link
Contributor

Glob checking will explode horribly if you run it from a sub-directory of the repo -- or, heaven forfend, outside the repository entirely.

In a non-JS project (or even a JS project) having a package.json in the repo root might not be the best thing. In this case one might create a folder to host files specific to using a tool and it is likely necessary that running npx requires your working directory to be this subfolder, so we have a conflict.

Example: https://github.com/TWiStErRob/github-workflows/pull/2/files

Luckily this doesn't affect the quoted repo, because it doesn't have paths/paths-ignores (yet).

Most of my repositories are Gradle/JVM ecosystem based, so if I wanted to set up this tool there, I would use the same pattern as in the above PR. The reason I chose NPM as delivery is because that's what I know a bit apart from Gradle, and is conveniently set up out of the box in GHA.

According to npx docs there's no CLI option to execute npx with a specific node_modules parent folder. There's a strange mention of $prefix, which look like something, but I don't understand it.

@TWiStErRob TWiStErRob changed the title Ability to disable glob verification / set root directory Ability to disable paths/ignores verification, or set root directory Jul 10, 2023
@mpalmer mpalmer added the pr-welcome This would be a good fix/feature, but the maintainer isn't planning on doing the work label Jul 10, 2023
@mpalmer
Copy link
Owner

mpalmer commented Jul 10, 2023

I'd be happy to merge a PR or two implementing either or both of these features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-welcome This would be a good fix/feature, but the maintainer isn't planning on doing the work
Projects
None yet
Development

No branches or pull requests

2 participants