Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong variable definition not captured #45

Open
habutre opened this issue Apr 12, 2023 · 1 comment
Open

Wrong variable definition not captured #45

habutre opened this issue Apr 12, 2023 · 1 comment
Labels
pr-welcome This would be a good fix/feature, but the maintainer isn't planning on doing the work

Comments

@habutre
Copy link

habutre commented Apr 12, 2023

Hi @mpalmer

I have stumbled in a tiny issue but since I am a foreign in Rust I do not feel able to propose a PR

when I define an env var like below I got no complains from action-validator

$ {{ vars.MY_VAR }}

When my action runs, it does not substitute the variable value as expected instead just print the literal value $ {{ vars.MY_VAR }}

I believe that the validator could mark it as an issue suggesting (nice to have) the follow as remediation

${{ vars.MY_VAR }}
@mpalmer mpalmer added the pr-welcome This would be a good fix/feature, but the maintainer isn't planning on doing the work label Apr 13, 2023
@mpalmer
Copy link
Owner

mpalmer commented Apr 13, 2023

Hi Rogério,

This feels like a facet of what would be caught by a solid implementation of #22 -- although the particular problem mentioned in that feature request is missing braces, a parser/validator for expressions would presumably also catch a $ { typo.

I'll mark this as pr-welcome as well, and hopefully someone will do the necessary at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-welcome This would be a good fix/feature, but the maintainer isn't planning on doing the work
Projects
None yet
Development

No branches or pull requests

2 participants