Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate the action and action-version exists in workflows #38

Open
award28 opened this issue Mar 6, 2023 · 3 comments · May be fixed by #39
Open

Validate the action and action-version exists in workflows #38

award28 opened this issue Mar 6, 2023 · 3 comments · May be fixed by #39
Labels
pr-welcome This would be a good fix/feature, but the maintainer isn't planning on doing the work

Comments

@award28
Copy link

award28 commented Mar 6, 2023

Background

The action-validator should validate that any actions in the - use: {action}@{version} format exist. If this is not the case, an error should be reported.

Scope of Work

  • When validating an action step, if the action step has the uses key, validate that the action and specific version exist in GitHub.
    • If this is not the case, throw an error.
@award28
Copy link
Author

award28 commented Mar 6, 2023

I'll start looking into this issue and add any details that I come across. Would be happy to raise a PR for this one.

@mpalmer
Copy link
Owner

mpalmer commented Mar 7, 2023

This would certainly be an interesting additional validation. My only reservation is that it would presumably slow down validation a bit because of the network calls. Putting it behind a flag (something like --remote-checks perhaps) would work around that concern.

I'd love to take a look at a PR when you've got one together.

@mpalmer mpalmer added the pr-welcome This would be a good fix/feature, but the maintainer isn't planning on doing the work label Mar 7, 2023
@award28
Copy link
Author

award28 commented Mar 18, 2023

@mpalmer The PR for this issue is ready for review when you have the time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-welcome This would be a good fix/feature, but the maintainer isn't planning on doing the work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants