Fix Issue #345 + #337 + Fix UserTests that failed/was incorrectly implemented #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added support for CRUD operations of Comments on Articles and Posts
…ementalUserExportNextPage" (+Async versions)
+ Fixed test UserTests.CanCreateUpdateSuspendAndDeleteUser could fail as it assumed the user was among the 100 to be returned but it is not (at least not now).
rwjdk
changed the title
abc516
pushed a commit
to abc516/ZendeskApi_v2
that referenced
this pull request
Oct 30, 2019
…/was incorrectly implemented (Speedygeek#349) * Test "CanCreateTicketWithDueDate" can't run on PCs that use dd/MM/yyyy as time format * Added Code to make tests work * - Added support for issue Speedygeek#330 - Added support for CRUD operations of Comments on Articles and Posts * Implementation of "Users.GetIncrementalUserExport" and "Users.GetIncrementalUserExportNextPage" (+Async versions) * Changes to PR based on @mozts2005’s request * Changed Assert Style * Fixed Issue Speedygeek#345 + Fixed test UserTests.CanCreateUpdateSuspendAndDeleteUser could fail as it assumed the user was among the 100 to be returned but it is not (at least not now). * Added missing Obsolete Attribute * Fix Issue Speedygeek#337 + Added missing tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Issue #345 + #337
+
Fixed test UserTests.CanCreateUpdateSuspendAndDeleteUser could fail as it assumed the user was among the 100 to be returned but it is not (at least not now).
+
Some test from last PR did not follow suggested style.