Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test "CanCreateTicketWithDueDate" can't run on PCs that use dd/MM/yyyy format #343

Merged
merged 1 commit into from
Jun 22, 2018

Conversation

rwjdk
Copy link

@rwjdk rwjdk commented Jun 21, 2018

I'm running the code on a PC that uses the European style date format (dd/MM/yyyy)

This test assumes that the machine uses MM/dd/yyyy format as the code does not specify a culture. By providing Invariant Culture To the Parse Method you are ensured that code will work no matter what format the PC it is run on have.

@CLAassistant
Copy link

CLAassistant commented Jun 21, 2018

CLA assistant check
All committers have signed the CLA.

@AppVeyorBot
Copy link

Copy link
Member

@mozts2005 mozts2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@mozts2005 mozts2005 merged commit 0143aaa into Speedygeek:master Jun 22, 2018
@mozts2005 mozts2005 added this to the 3.9.0 milestone Jun 23, 2018
abc516 pushed a commit to abc516/ZendeskApi_v2 that referenced this pull request Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants