Updates to support date changes in the Holiday API #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…M-dd ISO-8601 format)
|
I created a HolidayDateConverter because the API states a yyyy-MM-dd format (no time), however it appears the endpoint will accept the full datetime format. Depending on how strictly you want to follow the spec I can leave it or take it out. |
|
ISO-8601 format calls for both date and time. I think we should pull the converter. I just duble checked that the default date format used by json.net is ISO-8601. |
|
The converter has been removed. |
mozts2005
added a commit
that referenced
this pull request
Mar 13, 2016
Updates to support date changes in the Holiday API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Holiday date format recently changed from integer to yyyy-MM-dd ISO-8601 format.