Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filtering by container-id supports prefix matching with 12 or more characters. #217

Closed
hengyoush opened this issue Dec 21, 2024 · 1 comment · Fixed by #218
Closed

Filtering by container-id supports prefix matching with 12 or more characters. #217

hengyoush opened this issue Dec 21, 2024 · 1 comment · Fixed by #218
Labels
enhancement New feature or request

Comments

@hengyoush
Copy link
Contributor

hengyoush commented Dec 21, 2024 •
edited
Loading

Currently ptcpdump only support filter by full-length container-id or 12-characters short id, but the crictl ps command display 13-characters id which can't be filtered successfully.

I think filtering by container-id supports prefix matching with 12 or more characters is needed, what do you think?

If possible, i can submit a pr.
@mozillazg mozillazg added the enhancement New feature or request label Dec 21, 2024
@mozillazg
Copy link
Owner

@hengyoush Thanks for the suggestion! Feel free to send a pull request.

@hengyoush hengyoush mentioned this issue Dec 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support filter by container-id prefix matching 12 or more characters hengyoush/ptcpdump
2 participants
@mozillazg @hengyoush