Fixed the second controller doesn't show up problem #989

daoshengmu · 2019-03-08T00:41:00Z

Per #977. We find the second controller does not show up intermittently, and I notice it is because the model vector of ControllerContainer.cpp is not resized properly.

bluemarvin

I think this code would benefit from some clean up. I wonder if we could make it more flexible by keying off the reported caps instead of the type? And only use the type for the controller model file mapping?

bluemarvin · 2019-03-08T20:25:14Z

app/src/main/cpp/ControllerContainer.cpp

@@ -44,7 +44,7 @@ struct ControllerContainer::State {
  }

  void SetUpModelsGroup(const int32_t aModelIndex) {
-    if (models.size() >= aModelIndex) {
+    if (aModelIndex >= models.size()) {


Good catch.

bluemarvin · 2019-03-08T20:26:27Z

app/src/oculusvr/cpp/DeviceDelegateOculusVR.cpp

+    // the current workaround is checking if it is Quest.
+    return IsOculusQuest();
+  }
+


I find having two different Is6DOF() functions confusing. Also is it possible to use a Go 3DoF controller with 6DoF headsets?

One of Is6DOF() is for controllers, and the other one is for headsets. Currently, we only use ControllerState.Is6DOF() for getting the capability from controllers. We didn't have Is6DOF() requirement for headsets yet, I just prepare it for the future. Ideally, ovrInputHeadsetCapabilities should tell us the capability flag of headsets, but it doesn't work right now, and I have checked OVR mobile samples are also under the same situation.

I have done a try for using Go 3DOF controller with the Oculus 6DOF headset, I didn't see any possibility.

daoshengmu · 2019-03-08T21:06:02Z

I think this code would benefit from some clean up. I wonder if we could make it more flexible by keying off the reported caps instead of the type? And only use the type for the controller model file mapping?

yep. That's what I was doing. Probably, I am not doing good enough :)

daoshengmu self-assigned this Mar 8, 2019

daoshengmu requested review from bluemarvin and MortimerGoro March 8, 2019 00:41

ghost added the in progress label Mar 8, 2019

daoshengmu force-pushed the oculus6ofController branch from fdb4a16 to cb90afd Compare March 8, 2019 00:45

daoshengmu added 2 commits March 7, 2019 17:09

Adjust the way of Oculus 6DOF checking.

ab9d37c

Resolved the second controller disappear problem. (MozillaReality#977)

b5702f7

daoshengmu force-pushed the oculus6ofController branch from cb90afd to b5702f7 Compare March 8, 2019 01:10

MortimerGoro approved these changes Mar 8, 2019

View reviewed changes

bluemarvin approved these changes Mar 8, 2019

View reviewed changes

daoshengmu merged commit 38c334e into MozillaReality:master Mar 9, 2019

ghost removed the in progress label Mar 9, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed the second controller doesn't show up problem #989

Fixed the second controller doesn't show up problem #989

daoshengmu commented Mar 8, 2019

bluemarvin left a comment

bluemarvin Mar 8, 2019

bluemarvin Mar 8, 2019 •

edited by philip-lamb

Loading

daoshengmu Mar 8, 2019 •

edited

Loading

daoshengmu commented Mar 8, 2019

Fixed the second controller doesn't show up problem #989

Fixed the second controller doesn't show up problem #989

Conversation

daoshengmu commented Mar 8, 2019

bluemarvin left a comment

Choose a reason for hiding this comment

bluemarvin Mar 8, 2019

Choose a reason for hiding this comment

bluemarvin Mar 8, 2019 • edited by philip-lamb Loading

Choose a reason for hiding this comment

daoshengmu Mar 8, 2019 • edited Loading

Choose a reason for hiding this comment

daoshengmu commented Mar 8, 2019

bluemarvin Mar 8, 2019 •

edited by philip-lamb

Loading

daoshengmu Mar 8, 2019 •

edited

Loading