Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Fixes #618 Support debug and release builds on device simultaneously #908

Merged
merged 2 commits into from
Jan 18, 2019

Conversation

keianhzo
Copy link
Contributor

Fixes #618 Added support for simultaneous debug and release builds int he same device.

@keianhzo keianhzo requested review from jdm and MortimerGoro December 20, 2018 14:48
Copy link
Contributor

@MortimerGoro MortimerGoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

One question, why do we need to duplicate the logos?

@bluemarvin
Copy link
Contributor

Will this work correctly on Oculus? I assume when we install the debug version you will have to launch it from adb as the debug version won't be visible in the launcher?

@cvan
Copy link
Contributor

cvan commented Dec 20, 2018

One question, why do we need to duplicate the logos?

to easily differentiate between release and debug versions, if I had to guess.

I was going to create a version with a Debug ribbon on the edge:

image

but the grayscale version's good IMO 👍

@keianhzo
Copy link
Contributor Author

@MortimerGoro I change the logo just so it's more obvious that it's a debug build but that can be removed or changed for any other logo.

@rbarker it does work ok Oculus, just the store app will show in the apps shelf and the debug app will show in the unknown sources list. I couldn't find a way for the debug build to show in the apps shelf.

@keianhzo keianhzo force-pushed the simultaneous-debug-release branch from b7d74b0 to 71d4252 Compare December 21, 2018 09:41
@bluemarvin
Copy link
Contributor

I would prefer this be a user.properties option and not the default behavior at least for oculus but really for all platforms. Having two different FxR on a head set really complicates testing and development scripts.

@MortimerGoro MortimerGoro force-pushed the simultaneous-debug-release branch from 71d4252 to 17a21c7 Compare January 10, 2019 13:06
@MortimerGoro
Copy link
Contributor

+1 for the user.properties option.

I updated this PR with a new user property to enable the simultaneous builds

@MortimerGoro
Copy link
Contributor

Merging this. The dev sufix is only enabled via user.properties now so it will be harmless for tascluster

@MortimerGoro MortimerGoro merged commit 6e5bb72 into master Jan 18, 2019
@bluemarvin bluemarvin deleted the simultaneous-debug-release branch January 25, 2019 23:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants