This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Prevent auto-zooming when form field gets focus. Fixes #755 #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caseyyee
approved these changes
Nov 26, 2018
There was a problem hiding this comment.
✅ Works for me!
As per @keianhzo, the editable text field is the one that triggers zoom for me, but no longer seems to be an issue here.
Also tested a few login pages and zoom doesn't appear to be an issue any longer.
I think the zoom behavior is also controlled by meta viewport max and minimum zoom, which probably explains why it happens on some sites and not others.
cvan
approved these changes
Nov 26, 2018
There was a problem hiding this comment.
tested this on https://webxr.sh/editable and various login forms, including GMail, Outlook, and Wikipedia 👍
| @@ -706,6 +706,7 @@ private void vrPrefsWorkAround(Context aContext, Bundle aExtras) { | |||
| out.write("pref(\"webgl.enable-surface-texture\", true);\n".getBytes()); | |||
| out.write("pref(\"apz.allow_double_tap_zooming\", false);\n".getBytes()); | |||
| out.write("pref(\"dom.webcomponents.customelements.enabled\", true);\n".getBytes()); | |||
| out.write("pref(\"formhelper.autozoom\", false);\n".getBytes()); | |||
bluemarvin
force-pushed
the
prevent-zoom
branch
from
7887d04 to
43d0016
Compare
cvan
reviewed
Nov 26, 2018
| @@ -706,6 +706,8 @@ private void vrPrefsWorkAround(Context aContext, Bundle aExtras) { | |||
| out.write("pref(\"webgl.enable-surface-texture\", true);\n".getBytes()); | |||
| out.write("pref(\"apz.allow_double_tap_zooming\", false);\n".getBytes()); | |||
| out.write("pref(\"dom.webcomponents.customelements.enabled\", true);\n".getBytes()); | |||
| // Prevent autozoom when giving a form field focus. | |||
There was a problem hiding this comment.
nit: or a <div contenteditable>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.