This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Implement larger window on fullscreen. Handle VR video quality changes. #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uring VR playback.
caseyyee
approved these changes
Nov 23, 2018
There was a problem hiding this comment.
OK, so this is looking really good!
✅ Larger Fullscreen view.
✅ Sets Fullscreen aspect ratio.
✅ Works with the window resize feature.
✅ Works with element & video requestFullscreen, VR video tests at webxr.sh
The only inconsistencies I found was in what is reported back for window sizes. It's a issue that will need to addressed and should allow for Youtube to automatically adjust video quality, but we can fix as separately without blocking this PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #779 and #748