This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Fix stuck in fullscreen mode when exiting private browsing. Fixes #739 #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MortimerGoro: on
very interesting. good observation. do you know what fixes or causes a browser window change? |
caseyyee
approved these changes
Nov 22, 2018
MortimerGoro
force-pushed
the
fullscreen_private
branch
from
659884a to
c76ec07
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #739
I also found that the
Xbutton of private mode was only visible after a browser window change. The worldWidth was set toInfinityand also the 'X' widget got more size than needed on the browser widget update call. Fixed this issues too in this PR