Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Add a user property to disable app relaunch on crash #656

Merged
merged 1 commit into from
Oct 25, 2018
Merged

Conversation

MortimerGoro
Copy link
Contributor

I find the restart annoying while developing because the logs/stacktraces get back on the log history and may be lost.

Related issue: #651

@bluemarvin
Copy link
Contributor

Turning off the crash reporting in debug will make testing and working on crash reporting more painful. Maybe you can add config that can be set in user.properties? Something like disableCrashRestart=true? Then it isn't just a debug vs release thing?

@MortimerGoro
Copy link
Contributor Author

I like the user.properties approach. I'll update the PR.

@MortimerGoro MortimerGoro changed the title Disable Activity relaunch on crash on debug bulds Add a user property to disable app relaunch on crash Oct 24, 2018
@MortimerGoro
Copy link
Contributor Author

PR updated with the user.properties solution

Copy link
Contributor

@keianhzo keianhzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works good. Maybe we could also add a comment in the README so people are aware that it's available?

Copy link
Contributor

@keianhzo keianhzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what happened, started to comment like crazy, basically the above comment.

@keianhzo keianhzo dismissed their stale review October 24, 2018 21:55

Wrong review

@keianhzo keianhzo merged commit 06df4a4 into master Oct 25, 2018
@bluemarvin bluemarvin deleted the crash_debug branch November 13, 2018 23:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants