This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Recreate SwapChain before binding if the target FBO is invalid #3713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MortimerGoro
force-pushed
the
oculus_bind_eye_crash
branch
from
f17edab to
c485cfe
Compare
MortimerGoro
changed the title
MortimerGoro
force-pushed
the
oculus_bind_eye_crash
branch
from
c485cfe to
59a64e6
Compare
bluemarvin
approved these changes
Jul 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3712
This is a speculative fix. The crash address is the same (0x10) if I force the FBOs to be invalid and not added to the vector. @Softvision-RemusDranca is trying to find STRs.
I tried to force the FBOs to be invalid for 50 times using a counter and the app is able to recover using the fix included in the PR.