Picovr suffix

[keianhzo]

Pico now has a ROM baked version of FxR. We need to provide a suffix so QA can test staging build without colliding with the production appId.

[bluemarvin]

@keianhzo Maybe we should unify the suffix between WaveVR and pico? It would make scripting easier. Maybe .internal?

[keianhzo]

@bluemarvin Updated.

[bluemarvin]

The release build fails. Try ./gradlew assemblePicovrstoreArm64Release
Result:

> Task :app:processPicovrStoreArm64ReleaseAnnotationsWithJavac FAILED
ANTLR Tool version 4.5.3 used for code generation does not match the current runtime version 4.7.1ANTLR Runtime version 4.5.3 used for parser compilation does not match the current runtime version 4.7.1ANTLR Tool version 4.5.3 used for code generation does not match the current runtime version 4.7.1ANTLR Runtime version 4.5.3 used for parser compilation does not match the current runtime version 4.7.1warning: Current JDK version 1.8.0_201-b09 has a bug (https://bugs.openjdk.java.net/browse/JDK-8007720) that prevents Room from being incremental. Consider using JDK 11+ or the embedded JDK shipped with Android Studio 3.5+.
/home/randall/src/FirefoxReality/app/src/common/shared/org/mozilla/vrbrowser/VRBrowserActivity.java:102: error: cannot find symbol
public class VRBrowserActivity extends PlatformActivity implements WidgetManagerDelegate, ComponentCallbacks2, LifecycleOwner, ViewModelStoreOwner {
                                       ^
  symbol: class PlatformActivity
/home/randall/src/FirefoxReality/app/src/common/shared/org/mozilla/vrbrowser/browser/PermissionDelegate.java:15: error: cannot find symbol
import org.mozilla.vrbrowser.PlatformActivity;
                            ^
  symbol:   class PlatformActivity
  location: package org.mozilla.vrbrowser
/home/randall/src/FirefoxReality/app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/WebXRInterstitialController.java:11: error: cannot find symbol
import org.mozilla.vrbrowser.databinding.WebxrInterstitialControllerBinding;
                                        ^
  symbol:   class WebxrInterstitialControllerBinding
  location: package org.mozilla.vrbrowser.databinding
/home/randall/src/FirefoxReality/app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/WebXRInterstitialController.java:15: error: cannot find symbol
    private WebxrInterstitialControllerBinding mBinding;
            ^
  symbol:   class WebxrInterstitialControllerBinding
  location: class WebXRInterstitialController
4 errors
1 warning

FAILURE: Build failed with an exception.

[bluemarvin]

Also the build targets need to be updated for taskcluster:

diff --git a/tools/taskcluster/build_targets.py b/tools/taskcluster/build_targets.py
index d14d65dc..cdc1b4f4 100644
--- a/tools/taskcluster/build_targets.py
+++ b/tools/taskcluster/build_targets.py
@@ -39,6 +39,7 @@ platforms = {
    'wavevr': ['arm64'],
    'wavevrStore': ['arm64'],
    'picovr': ['arm64'],
+   'picovrStore': ['arm64'],
    'noapi': ['arm64', 'x86_64'],
 }

[bluemarvin]

@daoshengmu Should this:

FirefoxReality/app/src/common/shared/org/mozilla/vrbrowser/telemetry/GleanMetricsService.java

Line 160 in bda5ecf

Distribution.INSTANCE.getChannelName().set(DeviceType.isOculusBuild() ? "oculusvr" : BuildConfig.FLAVOR_platform);

be update to:

private static void setStartupMetrics() {
    String type = BuildConfig.FLAVOR_platform;
    if (DeviceType.isOculusBuild()) {
        type = "oculusvr";
    } else if (DeviceType.isPicoVR()) {
        type = "picovr";
    }
    Distribution.INSTANCE.getChannelName().set(type);
}

[daoshengmu]

@daoshengmu Should this:

FirefoxReality/app/src/common/shared/org/mozilla/vrbrowser/telemetry/GleanMetricsService.java

Line 160 in bda5ecf

Distribution.INSTANCE.getChannelName().set(DeviceType.isOculusBuild() ? "oculusvr" : BuildConfig.FLAVOR_platform);

be update to:

private static void setStartupMetrics() {
    String type = BuildConfig.FLAVOR_platform;
    if (DeviceType.isOculusBuild()) {
        type = "oculusvr";
    } else if (DeviceType.isPicoVR()) {
        type = "picovr";
    }
    Distribution.INSTANCE.getChannelName().set(type);
}

Yes. We can do this to keep our telemetry be matched. We might be able to consider to make DeviceType.isWaveBuild()) and type = 'wavevrStore' either. In that way, we can collect our data from different kinds of users. Then, in our queries, we can use channel==release to filter developers.

[daoshengmu]

@keianhzo We need to do the same change to here too, https://github.com/MozillaReality/FirefoxReality/blob/master/app/src/common/shared/org/mozilla/vrbrowser/telemetry/TelemetryWrapper.java#L148

[keianhzo]

@daoshengmu @bluemarvin This should be ready.

[daoshengmu]

LGTM.