Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Fixes tooltips #1622

Merged
merged 1 commit into from
Aug 21, 2019
Merged

Fixes tooltips #1622

merged 1 commit into from
Aug 21, 2019

Conversation

keianhzo
Copy link
Contributor

Fixes tooltips not being displayed.

@keianhzo keianhzo requested a review from bluemarvin August 21, 2019 16:46
bluemarvin
bluemarvin reviewed Aug 21, 2019
View reviewed changes
Copy link
Contributor

@bluemarvin bluemarvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What necessitated the switch to gecko.ThreadUtils? I ask because we are trying to remove all org.mozilla.gecko.* imports as that package is going to become private in GeckoView at some point.

@keianhzo
Copy link
Contributor Author

Not too much, there are alternatives but we are already using it across the app. Maybe we can file a follow up to refactor and land this?

@bluemarvin
Copy link
Contributor

Not too much, there are alternatives but we are already using it across the app. Maybe we can file a follow up to refactor and land this?

Okay, I was just curious what functionally the gecko.ThreadUtils added that the previous solution did not.

@bluemarvin bluemarvin merged commit 3c3c7dc into master Aug 21, 2019
@bluemarvin
Copy link
Contributor

#1626

@bluemarvin bluemarvin deleted the tooltips_fix branch August 26, 2019 16:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bluemarvin bluemarvin bluemarvin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keianhzo @bluemarvin