Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Fix JPG skyboxes. Do not require restart to switch to a custom env. #1513

Merged
merged 1 commit into from
Aug 6, 2019

Conversation

MortimerGoro
Copy link
Contributor

Fixes #1493

Also makes it possible to switch between stock and custom environments without a restart, even if they have different formats.

@keianhzo
Copy link
Contributor

keianhzo commented Aug 6, 2019

LGTM, great feature!

@MortimerGoro
Copy link
Contributor Author

MortimerGoro commented Aug 6, 2019

@jvonitter I have some ideas to improve the custom environments override. We can support many folders and automatically populate the environment list with the custom ones. That way you can switch between different stock and custom environments without having to enable/disable the override env option (which is a bit confusing)

@bluemarvin
Copy link
Contributor

@jvonitter I have some ideas to improve the custom environments override. We can support many folders and automatically populate the environment list with the custom ones. That way you can switch between different stock and custom environments without having to enable/disable the override env option (which is a bit confusing)

Well, the feature was only intended for testing new skyboxes. We should add telemetry to the feature to get an idea of how much it is being used (I'm also curious what are the more popular not-default built in skyboxes). There is a lot we can do to improve this if it is a popular feature.

@bluemarvin bluemarvin merged commit c5d3ca6 into master Aug 6, 2019
@jvonitter
Copy link
Contributor

made a new issue for the telemetry - #1524
we need to get through the data collection review before we can do it, but i'll update when that's done.

@elliotttate
Copy link

elliotttate commented Aug 7, 2019

@bluemarvin SideQuest now has Firefox Skybox sharing. In addition to telemetry, you can see stats on the number of downloads on each Skybox here: https://sidequestvr.com/#/app/184 (all of them will show in the "mods" section: https://sidequestvr.com/#/apps/4)

Not sure if this an indication of people wanting it, but this post about the Firefox skyboxes was the top post yesterday in the Oculus Quest sub: https://www.reddit.com/r/OculusQuest/comments/cm235m/watch_netflix_youtube_etc_and_surf_the_internet/

@bluemarvin bluemarvin deleted the skybox branch August 7, 2019 21:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom skyboxes not loading on Oculus Quest
5 participants