-
Notifications
You must be signed in to change notification settings - Fork 218
Conversation
I find the new spec a bit confusing though, when you check an option, as the pointer is on top of the radio button, it shows the grey hovered state instead of the checked state which might confuse the user. |
Thanks Manuel! Can we pass an apk to Nadja and team for them to see what you mean about the button state? |
@thenadj You can test the spec implementation in this APK: https://send.firefox.com/download/2f0aedb434403033/#G-whCzmp4Yt7h14j6tWvZg Please see my comments above. Thanks! |
1634853
to
b3804e4
Compare
@keianhzo Thanks for updating the radio buttons. They look great now. |
I find the hover color for checked radio button confusing. It feels like the button is not checked when hovered |
Ok, let's add 'hover-select' state. See updates in attached UIS-66. @jvonitter |
@thenadj @MortimerGoro Updated according to the latest spec, also added the Switch spec as I couldn't find any open issue for that. https://send.firefox.com/download/ae9485dfaf47b9b2/#C7W1IKwQQ2wlNPAw3u3OUw |
I don't see the color change on hover for off state of the switch. |
@bluemarvin I think the hover color difference between checked-hover and unchecked-hover is too subtle, do you mean that or you just don't see any change when you hover on an unchecked option and it just remains unchecked? |
I just don't see a difference between the off hover color red and the off selected state. They look exactly the same to me. So either it isn't working or they are too close to the same shade of red. |
The off switch color should be done in follow up. |
* Fixes radio button hover state wip * Updated hover and switch specs
* Fixes radio button hover state wip * Updated hover and switch specs
Fixes #1196 Fixes radio button hover state styles