Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push component should automatically recover from the server losing its uaid #871

Closed
data-sync-user opened this issue Jun 22, 2021 · 0 comments

Comments

@data-sync-user
Copy link
Collaborator

As noted in mozilla/application-services#3314 (comment) and subsequent comments, if the autopush server receives a 404 or 410 error when trying to delivery a push via one of the mobile bridges, it will completely drop the registration record for that uaid. AFAICT any attempts by the client to operate on that uaid will produce an error.

I don't think the push component currently handles this case well. In fact I don't see any codepaths that would case us to detect that self.uaid has become invalid and is being rejected by the server.

This seems like something that could be handled in verify_connection by:

  • Detecting the "uaid does not exist" error.
  • Registering a new uaid.
  • Reporting all existing subscriptions as expired.

We should also add some handling of this case in the update method, which clients may call when in this state in an attempt to repair this push subscriptions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants