Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make checksums optional #2255

Open
alexkirsz opened this issue Oct 5, 2024 · 2 comments · May be fixed by #2403
Open

Make checksums optional #2255

alexkirsz opened this issue Oct 5, 2024 · 2 comments · May be fixed by #2403

Comments

@alexkirsz
Copy link
Contributor

We run the uniffi bindgen with Bazel, and our rules ensure there can be no version mismatch between the Rust and foreign language bindings. This makes checksums purely redundant.

We would love to have the option to disable checksums entirely.
This was referenced Oct 5, 2024
Open
Merged
@mhammond
Copy link
Member

mhammond commented Oct 5, 2024

The checksums are to try and ensure the correct library is loaded at runtime, which the build process can't really ensure. #1789 also notes that the checksums aren't particularly adequate for proc-macros anyway, and I don't see an easy fix for that, so this is a reasonable discussion to have.

@bendk
Copy link
Contributor

bendk commented Oct 7, 2024

This seems reasonable to me. I think it could be a top-level field in uniffi.toml.

@yukibtc yukibtc mentioned this issue Nov 26, 2024
Closed
mhammond added a commit to mhammond/uniffi-rs that referenced this issue Jan 15, 2025
@mhammond
Add config option to omit the checking of library checksums.
036b3b3 
Fixes mozilla#2255
@mhammond mhammond linked a pull request Jan 15, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add config option to omit the checking of library checksums. mhammond/uniffi-rs
3 participants
@mhammond @bendk @alexkirsz