Skip to content
This repository has been archived by the owner on Mar 5, 2020. It is now read-only.

use the new mofo-style ESLint rc file #1557

Closed
Pomax opened this issue Jan 22, 2016 · 4 comments
Closed

use the new mofo-style ESLint rc file #1557

Pomax opened this issue Jan 22, 2016 · 4 comments

Comments

@Pomax
Copy link
Contributor

Pomax commented Jan 22, 2016

with MozillaFoundation/mofo-style#24 landed, we should tap into this new and improved linting solution.

@Pomax Pomax self-assigned this Jan 22, 2016
@Pomax Pomax added this to the January 29 milestone Jan 22, 2016
@Pomax Pomax mentioned this issue Jan 22, 2016
10 tasks
@Pomax Pomax modified the milestones: January 29, Feb 12 Feb 1, 2016
@Pomax Pomax added P1 and removed P1 labels Feb 2, 2016
@Pomax
Copy link
Contributor Author

Pomax commented Feb 3, 2016

A big problem here is that our new ESLINT rules are primed for "use ES6", which means that right now there are about 5000 errors pertaining it "please use arrow functions instead".

As discussed with @simonwex, one way forward here may be if we can somehow selectively apply ESLINT only to files that are updated after we turn on ESLINT linting, but this is an unresolved issue at the moment.

@Pomax Pomax added Blocked and removed P1 labels Feb 3, 2016
@simonwex
Copy link
Contributor

simonwex commented Feb 4, 2016

I'd like to talk through this during our next Engineering call. I've added it to that agenda.

@Pomax Pomax removed this from the Feb 12 milestone Feb 12, 2016
@Pomax
Copy link
Contributor Author

Pomax commented Feb 12, 2016

clearing the milestone here, because this is a very tricky problem, and is not happening without us figuring out how to do this for our entire app ecosystem.

@Pomax
Copy link
Contributor Author

Pomax commented Sep 9, 2016

mostly done, finally. three rules remain, they're tracked in a newer issue.

@Pomax Pomax closed this as completed Sep 9, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants