Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Side View “Welcome” screen and extension panel do not change color scheme based on the applied default Dark/Light themes #463

Open
acornestean opened this issue Aug 27, 2024 · 1 comment

Comments

@acornestean
Copy link

[Affected versions]:
Firefox Release 129.0.2
Firefox Beta 130.0
Firefox Nightly 131.0a1

[Affected Platforms]:
Windows, MacOS, Linux

[Steps to reproduce]:

  1. Enable the default Dark theme
  2. Install Side View version 0.6.5727 (based on the current master branch https://github.com/mozilla/side-view/releases/tag/0.5rc7) via about:debbugging
    OR
    via “Install Add-on From File” in Add-ons Manager (after setting xpinstall.signatures.required to false in about:config)
  3. Open the sidebar and observe the sidebar “Welcome” screen
  4. Open the extension panel from the extensions button on the toolbar and observe the panel
  5. Disable the default Dark theme so as the default theme is automatically reapplied OR enable the default Light theme
  6. Observe the sidebar “Welcome” screen
  7. Open the extension panel from the extensions button on the toolbar and observe the panel

[Expected result]:

  1. The sidebar “Welcome” screen color scheme should change based on the applied Dark/Light themes
  2. The extension panel color scheme should change based on the applied Dark/Light themes

[Actual result]:
Both the sidebar “Welcome” screen and the extension panel color schemes do not change based on the applied Dark/Light themes.

Dark theme applied:

2024-08-27_11h23_18

Default/Light theme applied:

2024-08-27_11h23_37

@jaredhirsch
Copy link
Member

Looks like dark/light theme management was added in #239 but perhaps we can do something a little simpler now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants