Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

running rustc under wrapper is only supported when invoked by cargo #1314

Closed
tofay opened this issue Sep 6, 2022 · 2 comments
Closed

running rustc under wrapper is only supported when invoked by cargo #1314

tofay opened this issue Sep 6, 2022 · 2 comments

Comments

@tofay
Copy link
Contributor

tofay commented Sep 6, 2022

#1280 adds support for using sccache when rustc is wrapped by another command, e.g /path/to/wrapper rustc.

This allows cargo users to use sccache as a rustc wrapper, and use another tool as a rustc wrapper for workspace members, resulting in commands like sccache /path/to/workspace/wrapper rustc.

This issue tracks the fact that running rustc with a wrapper is only supported by sccache when run under cargo (and hence the CARGO environment variable is defined). If a similar approach is taken by other build systems then sccache will fail to detect the compiler.

@lcmgh
Copy link

lcmgh commented Dec 13, 2022

Shouldn't this be closed as the PR is merged?

@drahnr
Copy link
Collaborator

drahnr commented Dec 13, 2022

That's correct, closed with #1280

@drahnr drahnr closed this as completed Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants