Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove very old draft ece-03 support #53

Open
jrconlin opened this issue Mar 18, 2021 · 2 comments
Open

Remove very old draft ece-03 support #53

jrconlin opened this issue Mar 18, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@jrconlin
Copy link
Collaborator

Data using this encoding format is very old and should no longer be supported. This may require some coordination with the Autopush Endpoint server to simply block incoming requests with appropriate messaging.

@jrconlin jrconlin added the enhancement New feature or request label Mar 18, 2021
@jrconlin
Copy link
Collaborator Author

In case folk are curious, this is what the server sees:

image

mozilla-services/autopush-rs#266

@rfk
Copy link
Contributor

rfk commented Mar 21, 2021

If I'm understanding correctly, the ece-03 draft defines the aesgcm encoding, which the graph above suggests is (unfortunately!) the most commonly used. The unused aesgcm128 scheme seems to come from an earlier thomson-02 draft, and as noted in issue comment here I don't think it is supported by this crate.

I think that, happily, we don't have anything to do here (although Desktop does, ref Bug 1230038). But I could easily be lost in the web of specs here, and would appreciate a second opinion on the chain of reasoning here and in the issue comment linked above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants