Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement $262.detachArrayBuffer for typed arrays #1527

Open
andreabergia opened this issue Jul 18, 2024 · 2 comments
Open

Implement $262.detachArrayBuffer for typed arrays #1527

andreabergia opened this issue Jul 18, 2024 · 2 comments
Labels
Arrays test262 harness Issues related to failing test262 tests, due to Rhino not yet support certain JS features

Comments

@andreabergia
Copy link
Contributor

Quite a few test cases for typed arrays fail because rhino lacks $262.detachArrayBuffer, which should be a implementation-defined way to detach an Array Buffer. For example, prototype/copyWithin/coerced-values-end-detached.js.

@p-bakker
Copy link
Collaborator

This should implement this operation based on this documentation

@p-bakker p-bakker added the test262 harness Issues related to failing test262 tests, due to Rhino not yet support certain JS features label Jul 20, 2024
@p-bakker
Copy link
Collaborator

Based on just looking at the NativeArrayBuffer it seems to me that is not just the test facility is missing, but that NativeArrayBuffer lacks the facilities to 'detach' as well

Could maybe be as straightforward as setting the internal (byte) buffer to null and adding some checks and throws

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arrays test262 harness Issues related to failing test262 tests, due to Rhino not yet support certain JS features
Projects
None yet
Development

No branches or pull requests

2 participants