Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only 3 lines of SQL visible until you resize the query window #788

Closed
chrismore opened this issue Jan 25, 2019 · 14 comments
Closed

Only 3 lines of SQL visible until you resize the query window #788

chrismore opened this issue Jan 25, 2019 · 14 comments
Labels
Milestone

Comments

@chrismore
Copy link

chrismore commented Jan 25, 2019

Issue Summary

A few months ago when viewing a redash query, my entire query window only display the top 3 lines of SQL while the rest is completely blank. I can only scroll within these 3 lines. It looks like a CSS or rendering issue.

Steps to Reproduce

  1. Open up any redash query
  2. Edit the source
  3. View the SQL

Expected results:

Seeing all of the SQL with scroll bars

Actual results:

Only 3 lines of SQL are visible and the rest of the query window is blank. You can scroll up/down, but only the top 3 lines are visible. If I resize the query window vertically (with the two horizontal lines below the save/execute buttons), the expected results happens, but only temporarily. If I refresh the page after resizing the query, the issue happens again. This started a few months ago and I have no clear path to resolution.

Screenshot of hidden query:

screen shot 2019-01-25 at 12 48 37 pm

Any other info e.g. Why do you consider this to be a bug? What did you expect to happen instead?

Technical details:

  • Redash Version: web
  • Browser/OS: Firefox Release channel + Mac OSX
  • How did you install Redash: Browser based, nothing to install. I tried to log out and back in with no hope.
@harterrt
Copy link

I've been experiencing the same bug for the last week as well.

@fbertsch
Copy link

Bump, there's at least 2 others in the fx-metrics channel who have experienced this.

@harterrt
Copy link

@rafrombrc, can you confirm someone is looking at this?

@chrismore
Copy link
Author

I also want to note that this is a Firefox-only bug. I do not experience this within Chrome. It could be related to scroll anchoring: https://bugzilla.mozilla.org/show_bug.cgi?id=1519644

@fbertsch
Copy link

@chrismore maybe disabling the scroll anchoring will help? Though I think that's nightly-only. If it's available in your config, set layout.css.scroll-anchoring.enabled to false. Let us know if that fixes things.

@chrismore
Copy link
Author

@fbertsch it works fine in nightly regardless of the value of layout.css.scroll-anchoring.enabled. I set it to both true and false and the bug isn't seen there.

@fbertsch
Copy link

@chrismore thanks for investigating, I couldn't get it to reproduce either.

@jezdez
Copy link

jezdez commented Feb 6, 2019

@chrismore @fbertsch I wasn't able to reproduce this in 65, were you?

@rafrombrc rafrombrc added this to the 20 milestone Feb 6, 2019
@jezdez
Copy link

jezdez commented Feb 6, 2019

@emtwo @washort I was able to reproduce this a few days ago, but can't anymore. Have you seen this recently?

@emtwo
Copy link

emtwo commented Feb 6, 2019

Likewise, I cannot reproduce this anymore.

@chrismore
Copy link
Author

In Firefox 65, I am unable to reproduce it anymore.

@jezdez
Copy link

jezdez commented Feb 7, 2019

Turns out this has not been an issue in Firefox anymore but Chrome still has it. Good news is it was fixed upstream via getredash#3412.

@rafrombrc Just to make sure, is this something we should close now or leave open until we've pulled in the change in the next rebase?

@rafrombrc
Copy link
Member

Let's leave it open until we merge.

@rafrombrc
Copy link
Member

Closing since this has been resolved in firefox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants