Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[User Interview Results] Queries in Redash should have "reviewed" flag #341

Closed
emtwo opened this issue Feb 21, 2018 · 6 comments
Closed
Milestone

Comments

@emtwo
Copy link

emtwo commented Feb 21, 2018

A reviewed query should be flagged as such and visible in the UI. This makes it easier for someone to both:

  1. Trust the results of the query
  2. Feel more comfortable forking the query to extend it

Additionally, it should be possible to search and filter queries by the "reviewed" flag.

@fbertsch
Copy link

Drive-by comment: The reviewer's name should be visible, along with the author's.

@rafrombrc rafrombrc added this to the 15 milestone May 30, 2018
@rafrombrc rafrombrc modified the milestones: 15, 16 Jul 11, 2018
@jezdez
Copy link

jezdez commented Jul 13, 2018

Tags will be part of getredash#2573 so I think this would cover the software feature part. The other part is to settle on a common list of tags that we can use in the data team.

@arikfr
Copy link

arikfr commented Jul 15, 2018

@jezdez that's a really cool use case for tags! I would love to hear how it works for you in a few months.

@rafrombrc rafrombrc modified the milestones: 16, 17 Jul 16, 2018
@jezdez
Copy link

jezdez commented Sep 17, 2018

@emtwo @fbertsch So now that tags are part of the queries UI, I suggest to start discussing ways to use this, e.g. with tags like reviewed:fbertsch for example. Is there anyone who'd be interested in formalizing the workflow for STMO users?

@emtwo
Copy link
Author

emtwo commented Sep 17, 2018

I think that this might integrate well with https://github.com/mozilla/stmocli. Since people are already using it to review queries, perhaps it can make an additional API call to add a tag to that query.

@rafrombrc rafrombrc modified the milestones: 17, 18, 19 Nov 7, 2018
@rafrombrc
Copy link
Member

Closing this since it's now something that can be done w tags and policy rather than a distinct feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants