Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long string that do not contain empty spaces are breaking the preview section layout in text widgets #326

Closed
madalincm opened this issue Jan 30, 2018 · 8 comments

Comments

@madalincm
Copy link

Steps to Reproduce:

  1. Open this dashboard: https://pipeline-sql.stage.mozaws.net/dashboard/-test-test
  2. Click on the option button - edit for the text widget that contains "11111111111111" string

Expected results:

The preview section is displayed correctly

Actual results:

Long strings are breaking the preview section.

Notes/Issues:

Build identifier: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0
Verified in FF58(Win7). Issue can be reproduced in STMO-stage
uichangespreviewtextwidget

@rafrombrc rafrombrc modified the milestones: 15, 14 Feb 21, 2018
@madalincm
Copy link
Author

Verified in FF58(Win7x64) in stmo-stage
Issue is still reporducing:
326reopen

@washort
Copy link

washort commented Mar 7, 2018

this is occurring in production (m12.1) as well.

@jezdez
Copy link

jezdez commented May 30, 2018

I think this was recently fixed upstream but can't find the commit right away.

@alison985
Copy link

Just checked this on pipeline-sql since the upstream merge work should be there now and it is still reproducing.

@alison985 alison985 self-assigned this Jun 5, 2018
@jezdez
Copy link

jezdez commented Jun 5, 2018

Ah, dang, must have been a different commit I saw. Sorry for the noise.

@jezdez
Copy link

jezdez commented Jun 18, 2018

I've closed #423 since the parent PR getredash#2580 has been merged. We'll keep this issue open though until we've merged upstream.

@alison985 alison985 added blocked and removed ready labels Jul 4, 2018
@rafrombrc rafrombrc modified the milestones: 15, 16 Jul 11, 2018
@alison985
Copy link

The upstream changes should have been caught in the latest rebase from upstream, so I'm moving this to done so @madalincm can check it.

@madalincm
Copy link
Author

Verified in FF61(Win7) in stmo-stage
Issue is no longer reproducing:
longtextwidget

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants