Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public dashboard link still accessible after the dashboard is archived #325

Open
madalincm opened this issue Jan 29, 2018 · 1 comment
Open

Comments

@madalincm
Copy link

Steps to Reproduce:

  1. Create a new dashboard
  2. Add a visualization widget and a text widget to it
  3. Generate a public link for the dashboard. Make a copy of this link
  4. Archive the dashboard
  5. Open the link generated in step 3 in a new window

Expected results:

The link should no longer be accessible.

Actual results:

The link is accessible. All the information from the archived dashboard can be seen using the generated public link.

Notes/Issues:

Build identifier: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0
Verified in FF58(Win7). Issue can be reproduced in STMO-stage
Link for the archived dashboard: https://pipeline-sql.stage.mozaws.net/dashboard/testarchived?page=1
Public link: https://pipeline-sql.stage.mozaws.net/public/dashboards/Ts0wecKqrOCsLAOD92rkDc5ydXXbI0MAtU0GhW1h?org_slug=default

@madalincm madalincm added the bug label Jan 29, 2018
@rafrombrc
Copy link
Member

Hrm. Yeah, this is a bit weird, bc since redash has no 'delete query' function, this effectively means it's impossible to make a public query no longer available. Maybe we should be showing that the query has been archived instead of the results?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants