Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the query search option in the all query page #323

Closed
madalincm opened this issue Jan 29, 2018 · 4 comments
Closed

Include the query search option in the all query page #323

madalincm opened this issue Jan 29, 2018 · 4 comments
Assignees
Milestone

Comments

@madalincm
Copy link

Issue Summary

We should include the search query functionality in the "All queries" page. At this moment in stage there are 2 distinct pages:

  1. All queries page: https://pipeline-sql.stage.mozaws.net/queries?page=1 - this page does not include a search field (except the on from the page header) and the user can't sort the queries displayed in this page.
    uichangesallqueriespage

  2. Search page: https://pipeline-sql.stage.mozaws.net/queries/search - when the user open this page he sees a message that there are no results found when in fact no search has been performed so far.
    uichangessearchpage

Having an extra Search tab seems redundant giving the fact that we have the search bar in the page header. Moving it to the all query page would make the search flow more natural to the user.

Technical details:

Build identifier: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0
Verified in STMO-stage

@madalincm
Copy link
Author

Verified in FF58(Win7x64) in stmo-stage
Issue is still reproducing

@jezdez
Copy link

jezdez commented May 30, 2018

This is related to #384

@rafrombrc
Copy link
Member

This should be fixed when the discovery branch is merged upstream and then into our repo.

@rafrombrc rafrombrc modified the milestones: 16, 17 Jul 16, 2018
@jezdez
Copy link

jezdez commented Sep 17, 2018

This has been fixed by merging the discovery branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants