Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update content sizes #73

Open
craigcook opened this issue Dec 19, 2019 · 7 comments
Open

Update content sizes #73

craigcook opened this issue Dec 19, 2019 · 7 comments

Comments

@craigcook
Copy link
Member

craigcook commented Dec 19, 2019

We're tinkering with revising content width tokens:

$content-sm: '432px'
$content-md: '688px'
$content-lg: '928px'
$content-xl: '1152px'

desktop_max__1312_

@stephaniehobson
Copy link
Contributor

One of these uses a 64px width grid spacer. If that's not a typo we need to document why and under what circumstances.

@stephaniehobson
Copy link
Contributor

In the scenario where we have content that is restricted to a medium width but displaying on a desktop sized monitor, what is the appropriate amount of grid spacing?

Put another way: if there was a large layout 4 column component above a medium layout 2 column layout would they both have the same amount of space between columns?

@craigcook
Copy link
Member Author

That's a good question. And put even another way, should the gutter width be determined by the viewport width or the content width?

My gut tells me narrower content should have narrower gutters, regardless of the viewport breakpoint. But that means columns won't always align if we're mixing containers on a page. If maintaining alignment is more important, then gutters should be set by the viewport breakpoint regardless of content width.

This is probably a question for @justinkropp and @dzingeek and it might be worth mocking it up or prototyping it both ways to see what feels right.

stephaniehobson added a commit that referenced this issue May 8, 2020
stephaniehobson added a commit that referenced this issue May 8, 2020
craigcook pushed a commit that referenced this issue May 8, 2020
@stephaniehobson
Copy link
Contributor

Note: this issue is still open because the grid spacing tokens haven't been added yet.

@stephaniehobson
Copy link
Contributor

So what do we want to call these new tokens?

I've been using this locally:

$h-grid-xs: 64px;
$h-grid-lg: 80px;

h = horizontal
xs/lg = what break point the size takes effect at.

We could also go with $h-grid and $h-grid-lg, where one is the default and the other is modified at that media query.

... or, you know, something entirely different from this. @craigcook thoughts?

@craigcook
Copy link
Member Author

Space between columns is usually called a gutter in graphic design, so we could do:

$gutter-md: 64px;
$gutter-lg: 80px;

But thinking about it more, that's probably too "jargony." I think a more jargon-neutral version would be:

$column-gap-md: 64px;
$column-gap-lg: 80px;

With the shirt-sizing convention I like to think of any "md" value as the norm and we scale either up or down from there. But with mobile-first we end up treating a small screen as the norm and only scaling up... but I don't know if that should dictate what we name our tokens. So it may not match the media query if we're using "md" tokens even on "sm" viewports, but I feel like it makes the token clearer. It's "the medium size" not "the size used on medium screens", if that makes sense.

Could we foresee a need for a smaller column gap unit? Should we add something like $column-gap-sm: 32px; just to round out the list, or is it a bad idea to make tokens until we know we need them?

@saumyasrivastava08
Copy link

can i work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants