-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update content sizes #73
Comments
One of these uses a 64px width grid spacer. If that's not a typo we need to document why and under what circumstances. |
In the scenario where we have content that is restricted to a medium width but displaying on a desktop sized monitor, what is the appropriate amount of grid spacing? Put another way: if there was a large layout 4 column component above a medium layout 2 column layout would they both have the same amount of space between columns? |
That's a good question. And put even another way, should the gutter width be determined by the viewport width or the content width? My gut tells me narrower content should have narrower gutters, regardless of the viewport breakpoint. But that means columns won't always align if we're mixing containers on a page. If maintaining alignment is more important, then gutters should be set by the viewport breakpoint regardless of content width. This is probably a question for @justinkropp and @dzingeek and it might be worth mocking it up or prototyping it both ways to see what feels right. |
Note: this issue is still open because the grid spacing tokens haven't been added yet. |
So what do we want to call these new tokens? I've been using this locally:
h = horizontal We could also go with ... or, you know, something entirely different from this. @craigcook thoughts? |
Space between columns is usually called a gutter in graphic design, so we could do:
But thinking about it more, that's probably too "jargony." I think a more jargon-neutral version would be:
With the shirt-sizing convention I like to think of any "md" value as the norm and we scale either up or down from there. But with mobile-first we end up treating a small screen as the norm and only scaling up... but I don't know if that should dictate what we name our tokens. So it may not match the media query if we're using "md" tokens even on "sm" viewports, but I feel like it makes the token clearer. It's "the medium size" not "the size used on medium screens", if that makes sense. Could we foresee a need for a smaller column gap unit? Should we add something like |
can i work? |
We're tinkering with revising content width tokens:
The text was updated successfully, but these errors were encountered: