-
Notifications
You must be signed in to change notification settings - Fork 10k
Bisecting a Regression
Brendan Dahl edited this page Aug 29, 2013
·
15 revisions
- git (on windows http://code.google.com/p/msysgit/downloads/list?q=full+installer+official+git)
- a server, if you have python installed that will work
- startup the git command line from above
- move a directory where you want it to live, if you're using a server that isn't python go into the directory where your wwwroot is
git clone https://github.com/mozilla/pdf.js.git
cd pdf.js/test
python test.py --noDownload
- open firefox and check http://localhost:8080/web/viewer.html goes to the pdf viewer
- go to
http://<yourserver>/pdf.js/web/viewer.html
- Download the bad PDF and save it in pdf.js/test/pdfs
- go to
<url from above>?file=../test/pdfs/<name of pdf>
and verify the PDF is broken
- Mark the current version as bad using
git bisect start
andgit bisect bad
- Open resource://pdf.js/build/pdf.js
- Find commit in the line with 'PDFJS.build = '
- Find version in the line with 'PDFJS.version = '
- A bugzilla patch contains the commits information near ' browser/extensions/pdfjs/content/build/pdf.js' [e.g. see https://bug871530.bugzilla.mozilla.org/attachment.cgi?id=750657, was added3d (good), will be 869b878 (bad)]
- If you know it was good in beta or aurora get the bad commit id from mxr Find the line with 'PDFJS.build = ' and copy the value in the single quotes e.g. 4e83123 auora - http://mxr.mozilla.org/mozilla-aurora/source/browser/extensions/pdfjs/content/build/pdf.js#24 beta - http://mxr.mozilla.org/mozilla-beta/source/browser/extensions/pdfjs/content/build/pdf.js#24
git checkout <commit id that you found above>
- Full refresh(ctr+shift+r) Firefox and verify the PDF no longer works.
- Mark it as good
git bisect good
- Full refresh(ctr+shift+r) of the viewer in Firefox
- If the current version works
git bisect good
- If it fails
git bisect bad
- Repeat same steps as above if it's bad
git bisect bad
if it's goodgit bisect good