Fix typo #375
Merged
Fix typo #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pdehaan
reviewed
May 10, 2020
| @@ -32,7 +32,7 @@ convict.addFormats(convict_format_with_moment) | |||
|
|
|||
| // Use this only if you have a .json configuration file in JSON5 format | |||
| // (i.e. with comments, etc.). | |||
| convict.addParser({extension: 'json', parse: JSON.parse}) | |||
| convict.addParser({extension: 'json', parse: JSON5.parse}) | |||
There was a problem hiding this comment.
@madarche are you sure this isn’t a typo? Using the native JSON.parse on json5 would throw an error here, and i believe the current json5 import from line 25 is currently unused.
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.npmjs.com/package/json5#json5parse