Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't add Open Tab to a Container #317

Closed
aplatypus opened this issue Mar 2, 2017 · 15 comments
Closed

Can't add Open Tab to a Container #317

aplatypus opened this issue Mar 2, 2017 · 15 comments

Comments

@aplatypus
Copy link

G'day ...

I think you need to consider the method for Add-ing a URL to a container. I am starting to set-up a container for my work wiki. I have a lot of tabs/url-s for various wiki pages.

I would like to be able to drag the TAB to the Container named "wiki" -- I found that impossible.

You definitely need to look at a simple way to do that -- I suggest something like the existing Bookmarks CTRL/SHIFT-B

Thank you,

aplatypus

@smichel17
Copy link

smichel17 commented Mar 4, 2017

A way to move a tab into/between containers would be very useful to me as well. The first thing I did on install was check whether I could move my existing tabs into containers.

I expected that there would be a Move to container submenu when right clicking on a tab.

@smichel17
Copy link

Related: #311

@a2sheppy
Copy link

Yes please. It's far too easy to wind up with a tab that's not in a container and needs to be moved into one. This is extra important when you first starting using containers, and have lots of already-open tabs that need to be categorized.

@groovecoder
Copy link
Member

@a2sheppy thanks for the feedback. Can you add your comment to #311 too? We're starting to do the product/UX work on that one.

@kjozwiak kjozwiak added this to the Stretch milestone Mar 30, 2017
@jonathanKingston
Copy link
Contributor

@aplatypus have you tried the new containers assignment feature.
Thinking about this some more, would it make more sense at setup time?

  1. User installs containers
  2. User is asked to categorise existing tabs
  3. Opening those websites again assigns to a the container mentioned.
  4. No further option is exposed to convert one tab to another.

Either way I think this makes sense in some form of management screen of assignments making it clear they should remove existing cookies

@groovecoder groovecoder removed this from the Stretch milestone Apr 28, 2017
@grahamperrin
Copy link

grahamperrin commented May 6, 2017

… containers assignment …

I can't find the feature.

Postscript

Found: #311 (comment) with reference to #306 and 3e657a2

Auto send users to sites they assigned to a container. Fixes #306

Then I remembered, Containers website assignment (2017-04-04), which I had found a few weeks ago, around the same time as https://twitter.com/KingstonTime/status/849333366684082176 – thanks @jonathanKingston but automation is the opposite of what I need.

For me, issues such as this #317 are blockers. I learnt to make great use of Tab Groups (The window is the container – the user groups things within a container – those things are tabs) so the idea of being unable to move a thing from one group to another is quite alien to me.

@jonathanKingston
Copy link
Contributor

Hey @grahamperrin,

Unfortunately moving from one container to another is a privacy issue which we really don't want to open up. Whilst this makes tab groups style usage an issue it would reduce the real reason why we are doing containers.

We are however all ears to ideas on how to solve this... without just moving across the container boundary. Moving from one container to another leaks cookie and tracking info from the sites in one container to another.

I can't find the feature.

We are working on making this more discoverable, thank you for hunting it down along with the commits etc!

Anyway thanks for your interest, I want to keep this open as maybe there is a path through here.

@aplatypus you can actually drag the (i) icon of the tab into a different tab. This copies the URL into a different container.

There probably is rationale on setup of a container to allow this behaviour too, however building it into common work flows isn't something I think we should support.

@smichel17
Copy link

smichel17 commented May 11, 2017

@jonathanKingston This seems like a better place to respond to what you said in #336 (comment):

After the initial hump of creating a container, I have rarely found I want to move containers.

For me it's mostly use case 2 in #428 (comment). When I'm browsing and I think of something I want to do/say using a different account, it's fairly cumbersome to click on the address bar, copy the url, open a new tab in the desired container, paste the url, hit enter, and then go find my place in the page. Even more so if I start to type my response before realizing I want to change accounts; that adds another several clicks and keystrokes switching between tabs.

Most of the time I do not actually want to convert the current tab, because I also want to continue using it afterwards; what I really want is a quick and easy shortcut that duplicates the current _URL_ into a new container. Maybe it also scrolls down to the current position (that's a pretty big ask and I wouldn't expect it in test pilot). Bonus points if it strips identifying info like clean links does did (also out of scope for now).

I will agree that a significant portion of the pain here is how clunky it is to choose which container you want to open a new tab in (unreliably hover, no keyboard shortcuts, searching through 10 different containers to find the one I want). It looks like the extension you made recently might help with that, although I anticipate it won't completely resolve the problem. (I'd enjoy being proved wrong, though!)

@a2sheppy
Copy link

a2sheppy commented May 11, 2017 via email

@jonathanKingston
Copy link
Contributor

@a2sheppy reimplementing this extension to not be about containers wouldn't be difficult. Tab management extensions will come in numbers does it really make sense to try and make this solve this use-case?

The only way I can see us shipping this is having a "Yes I understand, I just want tab highlighting" to enable these conversion features.

The fact is extensions already can and have solved this use case.

I would much rather solve:

  • Manage tabs into the new containers when:
    • Enabling containers
    • Creating a new container
  • Having a safer default tab which is isolated and allows you to move it into a container only once
  • Providing easier tools/methods for users to pick the right container when visiting a tab to reduce the "ah crap wrong container" feeling.

@jplatte
Copy link

jplatte commented Jun 6, 2017

@jonathanKingston I'd be perfectly fine with reloading the page when it is moved into a container. Maybe it should also be "reload in container" instead of "move to container". That should resolve the privacy issue, right?

EDIT: Maybe I misunderstood something? Seen as in #311 you suggested people to install ContextPlus instead and it does exactly this: It reloads the page in a different container. Is the concern here that reloading a page in a container could allow the server to detect that it is the same browser because the URL might contain identifying information?

@jonathanKingston
Copy link
Contributor

@jplatte as I mentioned here #311 (comment) I think users should just install contextPlus as this reduces the privacy benefit completely.

It reloads the page in a different container. Is the concern here that reloading a page in a container could allow the server to detect that it is the same browser because the URL might contain identifying information

Yup that is exactly the issue, moving containers even just the URL can identify the user across a container. Sure the risk is usually low however it is possible. Filtering parameters would require some form of add blocking tech and even that will never be perfect.

I think this is actually a duplicate of that bug anyway unless I'm not understanding the difference.

@jplatte
Copy link

jplatte commented Jun 6, 2017

Alright, I'll re-recommend Context Plus then. And I agree that this issue looks like a duplicate of #311.

@jonathanKingston
Copy link
Contributor

I think this is a duplicate of #311 and I also just closed that. Please reopen if you think there is a distinction.

@groovecoder
Copy link
Member

I think @jonathanKingston meant to close this when he marked it a duplicate of #311. (The resolution there was to use Context Plus for this.)

@groovecoder groovecoder marked this as a duplicate of #311 Jul 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants