Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync – Deleting a container in one browser does not remove the container from the other browser #2439

Closed
2 tasks done
acornestean opened this issue Nov 2, 2022 · 3 comments
Labels
bug Something is broken! Component: Sync Issues related to Sync functionality

Comments

@acornestean
Copy link

Before submitting a bug report

  • I updated to the latest version of Multi-Account Container and tested if I can reproduce the issue
  • I searched for existing reports to see if it hasn't already been reported

Step to reproduce

  1. Install the 8.1.0 version of Multi-Account Containers on 2 browsers and sign in with the same Firefox account on both. Make sure sync is enabled for both instances of the extension.
  2. On browser 1 (B1) create a container
  3. On browser 2 (B2) wait for the sync or manually sync and check that the created container appears in the MAC container list
  4. On B1, delete the container created at Step 2
  5. On B2 wait for the sync or manually sync and check for the presence of the previously deleted container
  6. Observe the container is still present on B2 after sync

Actual behavior

The container which was deleted on B1 still persists on B2 and is not removed i.e. sync does not work with deleted/removed containers.

Expected behavior

The container which was deleted on B1 should also be removed from B2 after syncing.

Additional informations

Sync was performed on 2 Nightlies (108.0a1/20221101213659)

Provide a copy of Troubleshooting Information page (optional)

No response

@acornestean
Copy link
Author

@stoically

I tested the currently available public version 8.0.7 and indeed, containers are no longer present on the second Firefox instance after syncing.

However, I’m testing the pre-release version 8.1.0 (https://github.com/mozilla/multi-account-containers/releases/tag/8.1.0) and it seems with this one, containers are still present in the second instance of Firefox after they are deleted from the first one. I followed the instructions you provided in #2240 but to no avail.

I observed that the MAC developer console correctly logs the deleted container (I named it DELETE and I mention this so it can be more easily followed in the console logs).

So as you can see in the image below, the deletedIdentityList array on the left (first FX instance) which has data from deleting the “DELETE” container matches what should be on the second instance of FX (on the right). The list of available containers also matches and the “DELETE” container is nowhere to be seen there.

2022-11-03_12h39_41

So far so good. Only issue is that the container is still present in the second instance of FX (see screenshots).

First FX instance:
2022-11-03_12h40_15

Second FX instance:
2022-11-03_12h40_25

The “DELETE” container does not go away and the only way to get rid of it is to manually delete it from the second FX instance.

Now, having the above conditions as a starting point, I added a new container in the first instance of FX, waited a few minutes, synced the second FX and it appears that the newly created container would not show up in the second FX until I manually removed the supposedly deleted “DELETED” container and waited a bit more. I did this a few times and each time I waited around 10-15 minutes to make sure I don’t jump the gun and give the sync a chance to do it’s thing, but the new container would not show up until I manually deleted the “deleted” container on the second FX.

Would you mind having a try at this using the 8.1.0 version please?

@dannycolin
Copy link
Collaborator

Fixed #2450

@acornestean
Copy link
Author

Verified as Fixed with version 8.1.1 of Multi-Account Containers. Deleted containers are removed from the second browser instance as expected.

Tested on the latest Nightly and Beta under Windows 10, Ubuntu 16.04 LTS and macOS 11.3.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken! Component: Sync Issues related to Sync functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants