Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Proton UI tabs are not highlighted by a color of container #2102

Closed
achernyakevich-sc opened this issue Aug 13, 2021 · 7 comments
Closed

Comments

@achernyakevich-sc
Copy link

  • Multi-Account Containers Version: 7.4.0
  • Operating System + Version: Windows 10, 21H1
  • Firefox Version: 91.0
  • Other installed Add-ons + Version + Enabled/Disabled-Status:
    Russian spellchecking dictionary dictionary 0.4.5.1webext true [email protected]
    Amazon.com extension 1.3 true [email protected]
    Bing extension 1.3 true [email protected]
    DuckDuckGo extension 1.1 true [email protected]
    Feedbro extension 4.9.10 true {a9c2ad37-e940-4892-8dce-cd73c6cbbc0c}
    Firefox Multi-Account Containers extension 7.4.0 true @testpilot-containers
    FoxyProxy Standard extension 7.5.1 true [email protected]
    Google extension 1.1 true [email protected]
    KeePassXC-Browser extension 1.7.9.1 true [email protected]
    Open in Sidebar extension 2019.7.8 true open-link-in-sidebar@afnankhan
    Simple Tab Groups extension 4.7 true simple-tab-groups@drive4ik
    Simple Translate extension 2.5.3 true simple-translate@sienori
    Tampermonkey extension 4.13.6136 true [email protected]
    User-Agent Switcher extension 1.4.1 true [email protected]
    Wikipedia (en) extension 1.1 true [email protected]
    Yandex extension 1.2 true [email protected]

Actual behavior

In Proton UI tabs are not highlighted by a color of container:
image

Expected behavior

As container "Scand" has blue color then tab should have some blue color highlighting the tab. In earlier version it was blue tab border.

Steps to reproduce

  1. Install Firefox 91.0.
  2. Open tab of the container.
  3. No visual highlighting.

Notes

Earlier highlighting was implemented as one colored border. Maybe there is a reason to highlight all boarders of the tab because in Proton UI tab selector looks like a independent button.

@achernyakevich-sc achernyakevich-sc changed the title In Proton UI tabs are not highlighted bye a color of container In Proton UI tabs are not highlighted by a color of container Aug 13, 2021
@achernyakevich
Copy link

As we could see that there was at least two other issues related to the same problem cause by forcing Proton UI to be turned on for everybody. It is really pity that to find which container tab belongs to you need to open this tab and look to URL field. :(

@shadowmage45
Copy link

I found that if I open about:config, and search for 'Proton', I was able to restore the above-tab color bar for containers by enabling the 'browser.proton.enabled' setting (previously was set to disabled, likely by me trying to fix some other Proton UI issues...).

Hope this helps...

image

@achernyakevich
Copy link

I found that if I open about:config, and search for 'Proton', I was able to restore the above-tab color bar for containers by enabling the 'browser.proton.enabled' setting (previously was set to disabled, likely by me trying to fix some other Proton UI issues...).

Hope this helps...

Thanks for your screenshot. I have rechecked my settings about Proton and have found that I have kept browser.proton.enabled set to false after my attempts to disable Proton UI. I did it because new tabs decoupled from page itself look really bad. But after update to Firefox 91 I have found that this setting do not disable Proton. :(

So our joint research results are:

  • if browser.proton.enabled=true (Proton is enabled) then tabs are colored.
  • if browser.proton.enabled=false (Proton expected to be disabled but in reality is not) then tabs coloring does not work.

I'm not sure will developers of this add-on treat as a bug. But if possible I would like have tabs colored even if browser.proton.enabled set to false.

@dtar2
Copy link

dtar2 commented Aug 14, 2021

Thank you @shadowmage45 and @achernyakevich. I have also confirmed these results. Setting browser.proton.enabled=true allows the tab colors to be displayed.

@arnofly
Copy link

arnofly commented Nov 22, 2021

Thank you too @shadowmage45. That's fix the "bug". Photon was definitively a better UI than Proton. That's why I set this variable to FALSE, as many people I think so... Mozilla loose users year after year, but don't care about opinion of historic users.

For me, the color line at the bottom of the tab was more readable (i am web developer).

@achernyakevich-sc
Copy link
Author

@arnofly BTW: the following issue and its comments could be useful for you - #2121

It provides info how to customize Firefox UI and color stripes for tabs of container (see, #2121 (comment) comment).

@dannycolin
Copy link
Collaborator

Closing since this was a Firefox issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants