Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some problems #1422

Closed
hightower5 opened this issue May 23, 2019 · 13 comments
Closed

Some problems #1422

hightower5 opened this issue May 23, 2019 · 13 comments

Comments

@hightower5
Copy link

There are some problems and missing features:

  • different number of icons in firefox setting and plugin setting
  • in firefox setting is missing whitespace between icon and text
  • need more icons e.g. email, multimedia, forum, filesharing, vpn
  • open this site in assigned container doesn't work
  • sort containers themself
  • multi language support e.g. german
@bugz8unny69
Copy link

open this site in assigned container doesn't work

What browser version and OS? I can't reproduce this here on Firefox 67.0 and Ubuntu 18.04?

sort containers themself

See #1377 and #1347

multi language support e.g. german

You can help by translating and submitting a PR for review.

need more icons e.g. email, multimedia, forum, filesharing, vpn

You have my thumbs up for this, this would really help in organize containers.

different number of icons in firefox setting and plugin setting
in firefox setting is missing whitespace between icon and text

Please show examples, e.g. screen shots?

@bugz8unny69
Copy link

open this site in assigned container doesn't work

What browser version and OS? I can't reproduce this here on Firefox 67.0 and Ubuntu 18.04?

I somewhat was able to reproduce this, once the site is assigned to a container and you open link in a new tab. Clicking Open in **Example** container appear to do nothing. Clicking Always remember my choice on and off and clicking Open in **Example** container multiple times did it finally succeed.

@Hultan
Copy link

Hultan commented May 24, 2019

Talking about icons, I would like to add that a setting for the main icon would be awesome. The current icon does not match my current theme at all. See the image below, the upper part is the default look, and it is barely visible. The lower part is when I have the mouse over the icon, and then it is visible. I would love if I could choose another icon that fits my current theme better.

multi-account

@hightower5
Copy link
Author

open this site in assigned container doesn't work

What browser version and OS? I can't reproduce this here on Firefox 67.0 and Ubuntu 18.04?

I somewhat was able to reproduce this, once the site is assigned to a container and you open link in a new tab. Clicking Open in **Example** container appear to do nothing. Clicking Always remember my choice on and off and clicking Open in **Example** container multiple times did it finally succeed.

Hi,
I don't know why I had yesterday some problems. Today it works sometimes.

Yesterday I checked the option "Always open in Banking". Closed tab. And entered the url in the address field. After this I got a new window with the question: Open this site in your assigned container?
-> Open in this Current Container? or Open in this Banking Container?
-> I have tried Open in this Banking Container? But nothing happened.
Today I need sometimes 2 or more clicks. If I select the option "Remember my decision for this site", then it works very well.

my sysytem: Windows 10 Pro Build 1809 x64, Mozilla Firefox Quantum 67.00 x64

@hightower5
Copy link
Author

hightower5 commented May 24, 2019

multi language support e.g. german

You can help by translating and submitting a PR for review.

What means PR for review? Are there some strings to translate, link?

need more icons e.g. email, multimedia, forum, filesharing, vpn

You have my thumbs up for this, this would really help in organize containers.

different number of icons in firefox setting and plugin setting
in firefox setting is missing whitespace between icon and text

Please show examples, e.g. screen shots?

Missing whitespace:
https://abload.de/img/container-tabs4zjwb.png

Different number of icons:
https://abload.de/img/settingsm1kii.png
https://abload.de/img/plugin4lj4m.png

@bugz8unny69
Copy link

What means PR for review? Are there some strings to translate, link?

PR stands for Pull Request, see the Tabs above. I am not sure if the developers have any documentation for translating. I would presume one would need to dig into the code or you could wait for developers response and contribute; which may take some time as they are currently busy with other stuff atm.

For future reference, you can drag and drop images into the text box. This makes it easier to review the images.

Missing whitespace:

container-tabs4zjwb

Different number of icons:

settingsm1kii
plugin4lj4m

@bugz8unny69
Copy link

@Hultan You might want to combine your report with this issue #1424 ?

@Hultan
Copy link

Hultan commented May 24, 2019

Thank you @LHorace, glad to see that this issue is already opened. I thought I could be lazy and add another icon issue with your issue, but I realize now that you were talking about other icons. Sorry :-)

@bugz8unny69
Copy link

Actually, it was open hour ago, heheh

@hightower5
Copy link
Author

Please Support different Languages.
And Vote for an internationalized extension.

@ciato
Copy link

ciato commented Jun 14, 2019

@hightower5

It seems like the clickable part is only on the left side of the button text. If you click there, the button works fine.

@hightower5
Copy link
Author

You are right. The highlighted text isn't clickable in the middle of the button text.

@kendallcorner
Copy link
Collaborator

Thanks for the input. I'm going to close this, because the items you've submitted have all either already been submitted (in which case, please vote (:+1:) or discuss on that issue to show your interest), or have been fixed.

  • different number of icons in firefox setting and plugin setting
  • in firefox setting is missing whitespace between icon and text

These were fixed if I'm understanding them correctly.

  • need more icons e.g. email, multimedia, forum, filesharing, vpn

This has already been submitted #1185

  • open this site in assigned container doesn't work

This should also have been fixed, but let me know if it's not.

  • sort containers themself

This has already been submitted #330

  • multi language support e.g. german

This has already been submitted: #529

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants