Skip to content
This repository has been archived by the owner on Sep 12, 2018. It is now read-only.

[core] Use combine 2.3.0 to simplify ValueParseError #343

Closed
ncalexan opened this issue Feb 22, 2017 · 2 comments
Closed

[core] Use combine 2.3.0 to simplify ValueParseError #343

ncalexan opened this issue Feb 22, 2017 · 2 comments
Labels
enhancement good first bug help wanted

Comments

@ncalexan
Copy link
Member

After #341, we'll have a ValueParseError in mentat_parser_utils. This can be simplified using the new functions in Marwes/combine#87, released in combine version 2.3.0. This ticket tracks removing the mapping code and traits in mentat_parser_utils in favour of map_range in combine.
@ncalexan
Copy link
Member Author

I'll link to the relevant code snippets after #341 is reviewed and landed.

@eoger
Copy link
Contributor

eoger commented Jan 24, 2018

This was done in d1ac752.

@eoger eoger closed this as completed Jan 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement good first bug help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ncalexan @eoger