Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room UI Redesign: Add inspect other player behavior #3246

Merged
merged 1 commit into from
Nov 12, 2020

Conversation

robertlong
Copy link
Contributor

@robertlong robertlong commented Oct 29, 2020

@brianpeiris brought up that you can inspect other players by right clicking. I was unaware of that at the time. This PR fixes that behavior and adds a hide button when inspecting other players.

Copy link
Contributor

@johnshaughnessy johnshaughnessy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the hide avatar button in the menu while inspecting an avatar, but it's not really possibly to interact with it -- should a button press toggle inspect instead of the button to be held down?

It seems like the inspect mode should be triggered when you click an avatar in the menu (so that the behavior is the same between the object list and avatar list). Is the idea to move the buttons from the sidebar into the menu in the main part of the screen?

@robertlong
Copy link
Contributor Author

@johnshaughnessy Idk. I agree it's a weird UX. I think we need to decide on one place to put the details. Inspect mode seems like a better option to me. Personally I'd like to merge this so we can show this behavior to DPX on staging and come up with a better solution.

@robertlong robertlong mentioned this pull request Nov 12, 2020
69 tasks
@robertlong robertlong merged commit bc44377 into room-ui-redesign Nov 12, 2020
@robertlong robertlong deleted the redesign/inspect-player branch November 12, 2020 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants