Room UI Redesign: People Sidebar #3148
Conversation
| > | ||
| {<DeviceIcon title={getDeviceLabel(person.context)} />} | ||
| {!person.context.discord && VoiceIcon && <VoiceIcon title={getVoiceLabel(person.micPresence)} />} | ||
| <p>{getPersonName(person)}</p> |
There was a problem hiding this comment.
Would like to be able to select/copy this text
There was a problem hiding this comment.
Hmm, I've made these buttons for accessibility reasons. Buttons have a default behavior which is to not allow text selection. IMO this is correct. If copying a user's name is important we should figure out the best place to put a copy user name button. This could be a right click menu or in the user's profile.
There was a problem hiding this comment.
Having this row be a button seems good to me -- it makes keyboard navigation easier and allows screen readers to parse it correctly. Does making the text in the button selectable with a user-select: text; css rule impact its accessibility? Keyboard navigation / button behavior seems to remain in tact in this example.
There was a problem hiding this comment.
It lets you select the text but it still triggers the button press. So you can't really copy the text. I think this is a relatively minor thing that we can tackle later.
| () => { | ||
| for (const person of people) { | ||
| if (person.presence === "room" && person.permissions && !person.permissions.mute_users) { | ||
| hubChannel.mute(person.id); |
There was a problem hiding this comment.
Not sure if I'm doing something wrong but I don't seem to be reaching the line. (Mute all doesn't seem to be working)
There was a problem hiding this comment.
Can you expand on this? Were you logged in? Was there another user in the room? Were they not muted?
There was a problem hiding this comment.
Took me a bit to figure out -- the case I was running into was that I was logged in as the same user twice, so the check for person.permissions.mute_users prevented the mute from going thru. Is this behavior correct? (Is "mute all" not supposed to apply to admins / owners?)
There was a problem hiding this comment.
It doesn't currently check for that: https://github.com/mozilla/hubs/blob/master/src/react-components/presence-list.js#L195
|
Can you give me some more reproduction steps for the more menu bug? I can't figure out how to trigger that. |
|
Here's a couple fixes for |
Redesign/people list quick fix
This PR adds the people sidebar and cleans up the styling for editing your own profile and viewing other users.